public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Greaves <david@dgreaves.com>
To: Olivier Galibert <galibert@pobox.com>,
	"Hack inc." <linux-kernel@vger.kernel.org>,
	marcel@holtmann.org, maxk@qualcomm.com,
	bluez-devel@lists.sourceforge.net
Subject: Re: [PATCH] Fix SCO on some bluetooth adapters (Success report for Belkin F8T012)
Date: Sat, 01 Jul 2006 13:22:41 +0100	[thread overview]
Message-ID: <44A66911.50309@dgreaves.com> (raw)
In-Reply-To: <20060420140517.GA72089@dspnet.fr.eu.org>

Olivier Galibert wrote:
> Some bluetooth adapters return an incorrect number of sco packets in
> READ_BUFFER_SIZE.  Add a quirk hook to fix it from the driver side,
> and use the hook for a first adapter.
> 
> Signed-off-by: Olivier Galibert <galibert@pobox.com>
> 
> ---
> 
> I tried to take Marcel Holtmann's remarks into account, but he seems
> unavailable to tell me whether he likes that version, so I'll send it
> to the whole shebang instead of just him this time.
> 
> The main point was "only the driver knows how to fix the problem",
> hence a function pointer quirk hook.  This is definitively not limited
> to broadcom USB devices, googling for "SCO MTU 64:0" has interesting
> results.
> 
> Pavel, '4' doesn't seem to be a value that happens in any correctly
> answering adapter, while 8 happens often.  Try "SCO MTU 64:4" and "SCO
> MTU 64:8" for comparison.
> 
> 
>  drivers/bluetooth/hci_usb.c      |   12 ++++++++++++
>  drivers/bluetooth/hci_usb.h      |    1 +
>  include/net/bluetooth/hci_core.h |    1 +
>  net/bluetooth/hci_event.c        |   16 ++++++++++++++--
>  4 files changed, 28 insertions(+), 2 deletions(-)
> 
> 841d7690e75189803907fbc4616b984087e7f89c

Replying to an old email about a patch that hasn't made it yet (at least
to 2.6.17.3).

Without this patch I can't use my Belkin F8T012 with the bluetooth alsa
sound driver (snd-bt-sco)

with it, I can :)

Thanks Olivier.

Is this likely to be merged?


David

PS, I tried the patch here:
 http://bluetooth-alsa.sourceforge.net/sco-mtu.patch
that is mentioned here:
 http://bluetooth-alsa.sourceforge.net/
but it doesn't work for me.

-- 

  reply	other threads:[~2006-07-01 12:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-20 14:05 [PATCH] Fix SCO on some bluetooth adapters Olivier Galibert
2006-07-01 12:22 ` David Greaves [this message]
2006-07-02  0:02   ` [PATCH] Fix SCO on some bluetooth adapters (Success report for Belkin F8T012) Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44A66911.50309@dgreaves.com \
    --to=david@dgreaves.com \
    --cc=bluez-devel@lists.sourceforge.net \
    --cc=galibert@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=maxk@qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox