Re: [PATCH] Airprime driver improvements to allow full speed EvDO transfers

Alan Cox
2006-07-13T14:39:49Z

On Iau, 2006-07-13 at 18:17 +0400, Sergei Organov wrote:
> This problem may occur with any tty driver that doesn't stop to insert
> data into the tty buffers in throttled state. And yes, there are such
> drivers in the tree. Before Paul's changes, the tty just dropped bytes
> that aren't accepted by ldisc, so this problem had no chances to arise.

You must honour throttle. That has always been the case. At all times
you should attempt to homour tty->receive_room and also ->throttle. If
you don't it breaks. There will always be some "reaction time" overruns.

> latter cases drivers that insert too much data without pushing to ldisc
> may cause similar problem. Anyway, you definitely know better what to do
> about it.

Might be a good idea to put a limiter in before 2.6.18 proper just to
trap any other drivers that have that bug. At least printk a warning and
refuse the allocation once there is say 64K queued. That way the driver
author gets a hint all is not well.

Alan