Re: [PATCH] Airprime driver improvements to allow full speed EvDO transfers

Andy Gay
2006-06-30T16:59:32Z

On Fri, 2006-06-30 at 01:52 -0700, Pete Zaitcev wrote:

> The idea to allocate a URB for every little user write bothers me as
> well. It was a dirty code thrown together quickly by someone who could
> not be bothered to use a circular buffer and two URBs. It was fine
> for the visor.c, but the Airprime is a higher performance card, and it
> can be used in a home gateway with a low-power CPU. I'm not happy.

I agree completely. I was already planning to work on improving the
write path at some point.
The read path is more important though, these networks are asymmetric -
Sierra Wireless specifies max 2.4Mbps download vs 153Kbps upload for the
EM5625 and MC5720, presumably the other devices are similar. So this
patch was focused on getting the best read performance.

>
> -- Pete