From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
kamezawa.hiroyu@jp.fujitsu.com, linux-kernel@vger.kernel.org,
hugh@veritas.com, kernel@kolivas.org, marcelo@kvack.org,
ak@suse.de
Subject: Re: [RFC 3/8] Move HIGHMEM counter into highmem.c/.h
Date: Wed, 05 Jul 2006 02:50:32 +1000 [thread overview]
Message-ID: <44AA9C58.2010707@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0607040819230.13534@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
> On Mon, 3 Jul 2006, Andrew Morton wrote:
>
>
>>>Ok. Will put a #ifdef CONFIG_HIGHMEM around that statement and the
>>>following one.
>>
>>That will take the patchset up to 27 new ifdefs. Is there a way of improving
>>that?
>
>
> Ideas are welcome. I can put some of the tests for zones together into one
> big #ifdef in mmzone.h but otherwise this is going to be difficult.
I don't think there's much point. They all look pretty straightforward,
and if you try doing something fancy it might just make it more fragile
or harder to read.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-07-04 16:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-03 21:55 [RFC 0/8] Reduce MAX_NR_ZONES and remove useless zones Christoph Lameter
2006-07-03 21:55 ` [RFC 1/8] Rework mmzone.h: Make DMA32 and HIGHMEM optional Christoph Lameter
2006-07-03 22:28 ` Andi Kleen
2006-07-03 21:55 ` [RFC 2/8] Make display of highmem counters conditional on CONFIG_HIGHMEM Christoph Lameter
2006-07-03 21:55 ` [RFC 3/8] Move HIGHMEM counter into highmem.c/.h Christoph Lameter
2006-07-04 5:47 ` KAMEZAWA Hiroyuki
2006-07-04 5:56 ` Christoph Lameter
2006-07-04 6:20 ` Andrew Morton
2006-07-04 15:20 ` Christoph Lameter
2006-07-04 16:50 ` Nick Piggin [this message]
2006-07-05 0:17 ` KAMEZAWA Hiroyuki
2006-07-03 21:55 ` [RFC 4/8] Remove display of counters for not available zones Christoph Lameter
2006-07-03 21:56 ` [RFC 5/8] swap_prefetch: Make use of ZONE_HIGHMEM dependend on CONFIG_HIGHMEM Christoph Lameter
2006-07-03 21:56 ` [RFC 6/8] Fix MAX_NR_ZONES array initializations in various arches Christoph Lameter
2006-07-03 21:56 ` [RFC 7/8] Fix strange uses of MAX_NR_ZONES Christoph Lameter
2006-07-03 21:56 ` [RFC 8/8] Fix i386 SRAT check for MAX_NR_ZONES Christoph Lameter
2006-07-04 5:52 ` KAMEZAWA Hiroyuki
2006-07-04 5:53 ` Christoph Lameter
2006-07-03 22:17 ` [RFC 0/8] Reduce MAX_NR_ZONES and remove useless zones Christoph Hellwig
2006-07-03 23:26 ` Christoph Lameter
2006-07-03 23:47 ` Andi Kleen
2006-07-03 23:53 ` Christoph Lameter
2006-07-04 12:04 ` Christoph Hellwig
2006-07-04 12:02 ` Christoph Hellwig
2006-07-04 15:10 ` Christoph Lameter
2006-07-04 15:23 ` Andi Kleen
2006-07-04 16:16 ` Christoph Lameter
2006-07-04 16:23 ` Arjan van de Ven
2006-07-04 16:41 ` Christoph Lameter
2006-07-04 16:47 ` Arjan van de Ven
2006-07-04 16:52 ` Andi Kleen
2006-07-04 16:25 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44AA9C58.2010707@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox