public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers/usb/input/ati_remote.c: autorepeat fix
@ 2006-07-05  4:33 Marko Macek
  0 siblings, 0 replies; only message in thread
From: Marko Macek @ 2006-07-05  4:33 UTC (permalink / raw)
  To: linux-kernel; +Cc: Vojtech Pavlik

When HZ is set to 250 (new default) or 100, the time span during which repeated
events from the device are ignored could be too small due to ms->jiffies rounding. 
This causes the auto repeat to kick in early making it impossible for the user 
to generate individual press/release events. Increate the timeout to compensate.

Signed-off-by: marko.macek@gmx.net	

---

--- linux-2.6.17.orig/drivers/usb/input/ati_remote.c	2006-06-29 21:18:15.000000000 +0200
+++ linux-2.6.17/drivers/usb/input/ati_remote.c	2006-07-02 21:36:14.000000000 +0200
@@ -155,9 +155,8 @@
  * events. The hardware generates 5 events for the first keypress
  * and we have to take this into account for an accurate repeat
  * behaviour.
- * (HZ / 20) == 50 ms and works well for me.
  */
-#define FILTER_TIME (HZ / 20)
+#define FILTER_TIME 60 /* msec */
 
 struct ati_remote {
 	struct input_dev *idev;
@@ -470,7 +469,7 @@
 		/* Filter duplicate events which happen "too close" together. */
 		if ((ati_remote->old_data[0] == data[1]) &&
 			(ati_remote->old_data[1] == data[2]) &&
-			time_before(jiffies, ati_remote->old_jiffies + FILTER_TIME)) {
+			time_before(jiffies, ati_remote->old_jiffies + msecs_to_jiffies(FILTER_TIME))) {
 			ati_remote->repeat_count++;
 		} else {
 			ati_remote->repeat_count = 0;



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-07-05  4:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-05  4:33 [PATCH] drivers/usb/input/ati_remote.c: autorepeat fix Marko Macek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox