public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Fulghum <paulkf@microgate.com>
To: "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
Cc: Pete@sc8-sf-spam2-b.sourceforge.net,
	Russell King <rmk+lkml@arm.linux.org.uk>,
	linux-usb-devel@lists.sourceforge.net, Greg KH <gregkh@suse.de>,
	linux-kernel@vger.kernel.org, Zaitcev <zaitcev@redhat.com>,
	alan@lxorguk.ukuu.org.uk
Subject: Re: [linux-usb-devel] Serial-Core: USB-Serial port current issues.
Date: Wed, 05 Jul 2006 08:40:31 -0500	[thread overview]
Message-ID: <44ABC14F.70004@microgate.com> (raw)
In-Reply-To: <20060704164257.03e70301@doriath.conectiva>

Luiz Fernando N. Capitulino wrote:
> |   take mutex
> |   take port lock
> | again:
> |   save local copy of icount
> |   release port lock
> |   get_mctrl
> |   take port lock
> |   if (icount changed)
> |     goto again
> |   update tty->hw_stopped
> |   release port lock
> |   release mutex
> 
>  Well, I think it'd work. But how can we keep track of 'icount'?
> Should the driver add 1 if it updates 'tty->hw_stopped'?

The only thing about icount that needs to be
tracked is that it changes, which indicates
an interrupt might have changed hw_stopped.
If icount changes at all, invalidate the last
reading of the state and do it again. The way
icount is incremented is not changed.

Like I said, it is really ugly. I was just looking
for a way of allowing get_mctrl to sleep if necessary.

-- 
Paul Fulghum
Microgate Systems, Ltd.

      parent reply	other threads:[~2006-07-05 13:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-13 22:28 Serial-Core: USB-Serial port current issues Luiz Fernando N. Capitulino
2006-06-14 15:28 ` Russell King
2006-06-14 20:38   ` Luiz Fernando N. Capitulino
2006-06-15  0:53     ` Pete Zaitcev
2006-06-15 13:29       ` Luiz Fernando N. Capitulino
2006-06-15 16:07         ` Greg KH
2006-06-15 16:21           ` Luiz Fernando N. Capitulino
2006-06-20 19:11   ` Luiz Fernando N. Capitulino
2006-06-21  2:32     ` Pete Zaitcev
2006-06-21 16:35       ` Luiz Fernando N. Capitulino
2006-06-21 16:43         ` Russell King
2006-06-21 21:15           ` Luiz Fernando N. Capitulino
2006-06-22  8:29             ` Russell King
2006-06-23 17:28               ` Luiz Fernando N. Capitulino
2006-06-26 22:26                 ` Greg KH
2006-06-27  0:49                   ` Paul Fulghum
2006-07-04 19:42                     ` Luiz Fernando N. Capitulino
2006-07-04 19:50                       ` Pete Zaitcev
2006-07-04 20:36                         ` Luiz Fernando N. Capitulino
2006-07-05 13:40                       ` Paul Fulghum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44ABC14F.70004@microgate.com \
    --to=paulkf@microgate.com \
    --cc=Pete@sc8-sf-spam2-b.sourceforge.net \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=lcapitulino@mandriva.com.br \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox