From: Henne <henne@nachtwindheim.de>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Neela.Kolli@engenio.com, kernel-janitors@lists.osdl.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [KJ] [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS
Date: Thu, 06 Jul 2006 22:33:49 +0200 [thread overview]
Message-ID: <44AD73AD.5080402@nachtwindheim.de> (raw)
In-Reply-To: <20060706131447.ed46c3cb.rdunlap@xenotime.net>
>> From: Henrik Kretzschmar <henne@nachtwindheim.de>
>>
>> Create an empty inline function to make the legacy megaraid-driver compile
>> without PROC_FS.
>> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
>> ---
>>
>> --- linux-2.6.18-rc1/drivers/scsi/megaraid.h 2006-06-18 03:49:35.000000000 +0200
>> +++ linux/drivers/scsi/megaraid.h 2006-07-06 21:39:59.000000000 +0200
>> @@ -1039,6 +1039,9 @@
>> static int proc_rdrv_30(char *, char **, off_t, int, int *, void *);
>> static int proc_rdrv_40(char *, char **, off_t, int, int *, void *);
>> static int proc_rdrv(adapter_t *, char *, int, int);
>> +#else
>> +static inline void
>> +mega_create_proc_entry(int index, struct proc_dir_entry *parent) {}
>> #endif
>>
>> static int mega_adapinq(adapter_t *, dma_addr_t);
>
> Already in -mm:
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm6/broken-out/drivers-scsi-megaraidc-add-a-dummy-mega_create_proc_entry-for-proc_fs=y.patch
Great, but isn't it better to put that define stuff into the headers?
Thanks and Greets,
Henne
next prev parent reply other threads:[~2006-07-06 20:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-06 19:54 [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS Henne
2006-07-06 20:14 ` [KJ] " Randy.Dunlap
2006-07-06 20:33 ` Henne [this message]
2006-07-06 20:39 ` Randy.Dunlap
2006-07-06 20:42 ` Adrian Bunk
2006-07-06 20:54 ` Henne
2006-07-06 21:59 ` Adrian Bunk
2006-07-07 6:32 ` Henne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44AD73AD.5080402@nachtwindheim.de \
--to=henne@nachtwindheim.de \
--cc=Neela.Kolli@engenio.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox