From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750818AbWGFUcb (ORCPT ); Thu, 6 Jul 2006 16:32:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750815AbWGFUcb (ORCPT ); Thu, 6 Jul 2006 16:32:31 -0400 Received: from server6.greatnet.de ([83.133.96.26]:27785 "EHLO server6.greatnet.de") by vger.kernel.org with ESMTP id S1750814AbWGFUca (ORCPT ); Thu, 6 Jul 2006 16:32:30 -0400 Message-ID: <44AD73AD.5080402@nachtwindheim.de> Date: Thu, 06 Jul 2006 22:33:49 +0200 From: Henne User-Agent: Thunderbird 1.5.0.4 (X11/20060527) MIME-Version: 1.0 To: "Randy.Dunlap" Cc: Neela.Kolli@engenio.com, kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [KJ] [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS References: <44AD6A5A.5060403@nachtwindheim.de> <20060706131447.ed46c3cb.rdunlap@xenotime.net> In-Reply-To: <20060706131447.ed46c3cb.rdunlap@xenotime.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org >> From: Henrik Kretzschmar >> >> Create an empty inline function to make the legacy megaraid-driver compile >> without PROC_FS. >> Signed-off-by: Henrik Kretzschmar >> --- >> >> --- linux-2.6.18-rc1/drivers/scsi/megaraid.h 2006-06-18 03:49:35.000000000 +0200 >> +++ linux/drivers/scsi/megaraid.h 2006-07-06 21:39:59.000000000 +0200 >> @@ -1039,6 +1039,9 @@ >> static int proc_rdrv_30(char *, char **, off_t, int, int *, void *); >> static int proc_rdrv_40(char *, char **, off_t, int, int *, void *); >> static int proc_rdrv(adapter_t *, char *, int, int); >> +#else >> +static inline void >> +mega_create_proc_entry(int index, struct proc_dir_entry *parent) {} >> #endif >> >> static int mega_adapinq(adapter_t *, dma_addr_t); > > Already in -mm: > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm6/broken-out/drivers-scsi-megaraidc-add-a-dummy-mega_create_proc_entry-for-proc_fs=y.patch Great, but isn't it better to put that define stuff into the headers? Thanks and Greets, Henne