From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751139AbWGGGao (ORCPT ); Fri, 7 Jul 2006 02:30:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751194AbWGGGao (ORCPT ); Fri, 7 Jul 2006 02:30:44 -0400 Received: from server6.greatnet.de ([83.133.96.26]:38046 "EHLO server6.greatnet.de") by vger.kernel.org with ESMTP id S1751058AbWGGGao (ORCPT ); Fri, 7 Jul 2006 02:30:44 -0400 Message-ID: <44ADFFEA.1060508@nachtwindheim.de> Date: Fri, 07 Jul 2006 08:32:10 +0200 From: Henne User-Agent: Thunderbird 1.5.0.4 (X11/20060527) MIME-Version: 1.0 To: Adrian Bunk Cc: "Randy.Dunlap" , Neela.Kolli@engenio.com, kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [KJ] [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS References: <44AD6A5A.5060403@nachtwindheim.de> <20060706131447.ed46c3cb.rdunlap@xenotime.net> <44AD73AD.5080402@nachtwindheim.de> <20060706204252.GV26941@stusta.de> <44AD78A1.5010708@nachtwindheim.de> <20060706215957.GX26941@stusta.de> In-Reply-To: <20060706215957.GX26941@stusta.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org >> The header I mean is /drivers/scsi/megaraid.h and is only used by megaraid.c. >> And there are the prototypes, in dependency of CONFIG_PROC_FS, for all these other proc-related functions. >> Thats why I decided to make the change there and not in megaraid.c . > > Prototypes for static functions don't belong into header files. > > That this has been done in megaraid.h in the past is something that > should be cleaned up, not a good example. > > cu > Adrian Allright, thats that kind of answer I wanted to hear. :) Thanks and Greets, Henne