Re: [PATCH] Limit VIA and SIS AGP choices to x86

Ben Pfaff
2006-07-05T18:24:39Z

Andrew Morton <akpm@osdl.org> writes:

> On Wed, 5 Jul 2006 11:57:25 -0600
> Matthew Wilcox <matthew@wil.cx> wrote:
>
>> As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP
>> chipsets available.
>>
>> ...
>>
>> config AGP_SIS
>> tristate "SiS chipset support"
>> - depends on AGP
>> + depends on AGP && X86
>
> I never know what to do here.
>
> Sure, the driver will not be used on that architecture. But there is some
> benefit in being able to cross-compile that driver on other architectures
> anyway. Sometimes it will pick up missed #includes, sometimes printk
> mismatches, various other assumptions which might be OK for x86 right now
> but which might cause problems in the future.

Should we have a NONNATIVE config option analogous to
EXPERIMENTAL, so that it could be expressed as
depends on AGP && (X86 || NONNATIVE)
Seems to express the actual intentions.
--
Ben Pfaff
email: blp@cs.stanford.edu
web: http://benpfaff.org