Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch

Jean Delvare
2006-07-27T21:23:08Z

Hi Tony & Krzysztof,

> > I think it would be different if trying to select something which
> > can't be selected automatically resulted in a warning. I think
> > I have to look at it then, but for now I'll use something like
> > "depends on (FB_CIRRUS=m && I2C && I2C_ALGOBIT) ||
> > (FB_CIRRUS=y && I2C=y && I2C_ALGOBIT=y)".
>
> Well if the i2c code happens to depend on another module, I hope
> that Jean would warn us in a timely manner :-). And even if Jean
> failed to do so, it would immediately result in a compile
> error/warning which should lead to an easy fix.

I2C and I2C_ALGOBIT are very unlikely to ever depend on anything, so
this isn't a problem.

> I still prefer 'select' just because it's easier to parse, but
> either way is okay, though your method takes me a few more seconds
> to understand.

The Right Way (TM) is to depend on I2C but select I2C_ALGOBIT. I have
plans to hide I2C_ALGOBIT from the configuration menu - the user should
never have to explicitely select it, it's only an helper module. So if
you depend on it, you'll be screwed.

--
Jean Delvare