Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch

Antonino A. Daplas
2006-07-10T11:27:25Z

Krzysztof Halasa wrote:
> "Antonino A. Daplas" <adaplas@pol.net> writes:
>
>> There are better reasons (ie, smaller patch), but worse readability is not
>> one of them.
>>
>> I could more easily grasp the code flow of cirrusfb_register() if you
>> just inserted "cirrusfb_create_i2c_buses()" instead of:
>
> Feel free to add another patch, while I don't see a need I have nothing
> against :-)

No, you fix the patch. And while your at it, check your Kconfig
dependencies, ie check for impossible combinations such as CONFIG_I2C=m,
CONFIG_FB_CIRRUS=y.

Tony