Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch

Krzysztof Halasa
2006-07-10T13:30:39Z

"Antonino A. Daplas" <adaplas@pol.net> writes:

> Eventually, I'm the one who's going to maintain the code, most
> of the drivers in the video directory are practically abandoned.

BTW, it's fortunate that you are maintaing it. The I2C code in cirrusfb
uses vga_wseq() and vga_rseq(). Is it safe WRT races between I2C
adapter code and fb code? I don't see any locking here, and both
functions are non-atomic (write merging and posting will not break it,
but it looks like I need a lock for concurent access).
--
Krzysztof Halasa