[PATCH 2.6.18-rc1 1/1] arch/x86-64: A few trivial spelling and grammar fixes

[PATCH 2.6.18-rc1 1/1] arch/x86-64: A few trivial spelling and grammar fixes

[Adam Henley]

A few trivial spelling and grammar mistakes picked up in
"arch/x86_64/aperture.c", "arch/x86_64/crash.c" and
"arch/x86_64/apic.c". I think all are correct fixes but am ever aware
of my fallibility :o) This is my first patch submission so all
feedback is appreciated, esp. WRT CCing to Linus, Andi and
trivial@kernel.org, is this correct? And which is the most appropriate
kernel version to diff against? If any.

Should apply cleanly to 2.6.18-rc1

Signed-off-by: Adam Henley <adamazing@gmail.com>

-  adam

diff --git a/arch/x86_64/kernel/aperture.c b/arch/x86_64/kernel/aperture.c
index 58af8e7..d5f6f56 100644
--- a/arch/x86_64/kernel/aperture.c
+++ b/arch/x86_64/kernel/aperture.c
@@ -48,7 +48,7 @@ static u32 __init allocate_aperture(void

 	/*
 	 * Aperture has to be naturally aligned. This means an 2GB aperture won't
-	 * have much chances to find a place in the lower 4GB of memory.
+	 * have much chance of finding a place in the lower 4GB of memory.
 	 * Unfortunately we cannot move it up because that would make the
 	 * IOMMU useless.
 	 */
diff --git a/arch/x86_64/kernel/apic.c b/arch/x86_64/kernel/apic.c
index 2b8cef0..194b826 100644
--- a/arch/x86_64/kernel/apic.c
+++ b/arch/x86_64/kernel/apic.c
@@ -400,7 +400,7 @@ void __cpuinit setup_local_APIC (void)
 	value |= APIC_SPIV_APIC_ENABLED;

 	/*
-	 * Some unknown Intel IO/APIC (or APIC) errata is biting us with
+	 * Some unknown Intel IO/APIC (or APIC) errata are biting us with
 	 * certain networking cards. If high frequency interrupts are
 	 * happening on a particular IOAPIC pin, plus the IOAPIC routing
 	 * entry is masked/unmasked at a high rate as well then sooner or
@@ -951,7 +951,7 @@ #endif
 	 * We take the 'long' return path, and there every subsystem
 	 * grabs the appropriate locks (kernel lock/ irq lock).
 	 *
-	 * we might want to decouple profiling from the 'long path',
+	 * We might want to decouple profiling from the 'long path',
 	 * and do the profiling totally in assembly.
 	 *
 	 * Currently this isn't too much of an issue (performance wise),
diff --git a/arch/x86_64/kernel/crash.c b/arch/x86_64/kernel/crash.c
index d8d5750..324a5ed 100644
--- a/arch/x86_64/kernel/crash.c
+++ b/arch/x86_64/kernel/crash.c
@@ -68,7 +68,7 @@ static void crash_save_this_cpu(struct p
 	 * for the data I pass, and I need tags
 	 * on the data to indicate what information I have
 	 * squirrelled away.  ELF notes happen to provide
-	 * all of that that no need to invent something new.
+	 * all of that, no need to invent something new.
 	 */

 	buf = (u32*)per_cpu_ptr(crash_notes, cpu);

Re: [PATCH 2.6.18-rc1 1/1] arch/x86-64: A few trivial spelling and grammar fixes

[Alan Cox]

Ar Sad, 2006-07-08 am 18:27 +0100, ysgrifennodd Adam Henley:
> -	 * have much chances to find a place in the lower 4GB of memory.
> +	 * have much chance of finding a place in the lower 4GB of memory.
>  	 * Unfortunately we cannot move it up because that would make the
>  	 * IOMMU useless.

OK (just s/chance/chance/ is enough)

> -	 * Some unknown Intel IO/APIC (or APIC) errata is biting us with
> +	 * Some unknown Intel IO/APIC (or APIC) errata are biting us with

Yes

> -	 * we might want to decouple profiling from the 'long path',
> +	 * We might want to decouple profiling from the 'long path',
>  	 * and do the profiling totally in assembly.

Yes

> -	 * all of that that no need to invent something new.
> +	 * all of that, no need to invent something new.

Yes (or that. There is no need)

Alan

Re: [PATCH 2.6.18-rc1 1/1] arch/x86-64: A few trivial spelling and grammar fixes

[Adam Henley]

Edited patch.

diff --git a/arch/x86_64/kernel/aperture.c b/arch/x86_64/kernel/aperture.c
index 58af8e7..d5f6f56 100644
--- a/arch/x86_64/kernel/aperture.c
+++ b/arch/x86_64/kernel/aperture.c
@@ -48,7 +48,7 @@ static u32 __init allocate_aperture(void

       /*
        * Aperture has to be naturally aligned. This means an 2GB aperture won't
-        * have much chances to find a place in the lower 4GB of memory.
+        * have much chance to find a place in the lower 4GB of memory.
        * Unfortunately we cannot move it up because that would make the
        * IOMMU useless.
        */
diff --git a/arch/x86_64/kernel/apic.c b/arch/x86_64/kernel/apic.c
index 2b8cef0..194b826 100644
--- a/arch/x86_64/kernel/apic.c
+++ b/arch/x86_64/kernel/apic.c
@@ -400,7 +400,7 @@ void __cpuinit setup_local_APIC (void)
       value |= APIC_SPIV_APIC_ENABLED;

       /*
-        * Some unknown Intel IO/APIC (or APIC) errata is biting us with
+        * Some unknown Intel IO/APIC (or APIC) errata are biting us with
        * certain networking cards. If high frequency interrupts are
        * happening on a particular IOAPIC pin, plus the IOAPIC routing
        * entry is masked/unmasked at a high rate as well then sooner or
@@ -951,7 +951,7 @@ #endif
        * We take the 'long' return path, and there every subsystem
        * grabs the appropriate locks (kernel lock/ irq lock).
        *
-        * we might want to decouple profiling from the 'long path',
+        * We might want to decouple profiling from the 'long path',
        * and do the profiling totally in assembly.
        *
        * Currently this isn't too much of an issue (performance wise),
diff --git a/arch/x86_64/kernel/crash.c b/arch/x86_64/kernel/crash.c
index d8d5750..324a5ed 100644
--- a/arch/x86_64/kernel/crash.c
+++ b/arch/x86_64/kernel/crash.c
@@ -68,7 +68,7 @@ static void crash_save_this_cpu(struct p
        * for the data I pass, and I need tags
        * on the data to indicate what information I have
        * squirrelled away.  ELF notes happen to provide
-        * all of that that no need to invent something new.
+        * all of that. There is no need to invent something new.
        */

       buf = (u32*)per_cpu_ptr(crash_notes, cpu);

Re: [PATCH 2.6.18-rc1 1/1] arch/x86-64: A few trivial spelling and grammar fixes

[Andi Kleen]

On Saturday 08 July 2006 20:50, Adam Henley wrote:
> Edited patch.

What edited? 

The white space seems worse than before. I already have the previous patch
now.

Also when you resubmit a patch please always add a complete changelog

-Andi

Re: [PATCH 2.6.18-rc1 1/1] arch/x86-64: A few trivial spelling and grammar fixes

[Adam Henley]

On 10/07/06, Andi Kleen <ak@suse.de> wrote:
> On Saturday 08 July 2006 20:50, Adam Henley wrote:
> > Edited patch.
>
> What edited?
>
> The white space seems worse than before. I already have the previous patch
> now.
>
> Also when you resubmit a patch please always add a complete changelog
>
> -Andi
>

Apologies Andi, white-space munging is probably the fault of gmail,
despite using plain text only, I'll try and use Thunderbird from now
on. The changes to the patch were pursuant to Alan's suggestions:

On 08/07/06, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> Ar Sad, 2006-07-08 am 18:27 +0100, ysgrifennodd Adam Henley:
> > -      * have much chances to find a place in the lower 4GB of memory.
> > +      * have much chance of finding a place in the lower 4GB of memory.
> >        * Unfortunately we cannot move it up because that would make the
> >        * IOMMU useless.
>
> OK (just s/chance/chance/ is enough)
>
>   <snip>
>
> > -      * all of that that no need to invent something new.
> > +      * all of that, no need to invent something new.
>
> Yes (or that. There is no need)
>
> Alan
>
>

Would you like me to resubmit the patch with a complete changelog and
correct whitespace? Sorry for wasting your time over what should have
been such a simple patch.

Thanks,

-adam

Re: [PATCH 2.6.18-rc1 1/1] arch/x86-64: A few trivial spelling and grammar fixes

[Arjan van de Ven]

> 
> Apologies Andi, white-space munging is probably the fault of gmail,
> despite using plain text only, I'll try and use Thunderbird from now
> on.

DOOOOOM


please read

http://mbligh.org/linuxdocs/Email/Clients/Thunderbird

before thinking that thunderbird is better than gmail ;-)

Greetings,
   Arjan van de Ven

Re: [PATCH 2.6.18-rc1 1/1] arch/x86-64: A few trivial spelling and grammar fixes

[Antonino A. Daplas]

Arjan van de Ven wrote:
>> Apologies Andi, white-space munging is probably the fault of gmail,
>> despite using plain text only, I'll try and use Thunderbird from now
>> on.
> 
> DOOOOOM
> 
> 
> please read
> 
> http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
> 
> before thinking that thunderbird is better than gmail ;-)

It's not that hopeless, I use thunderbird + gmail + an external
editor (emacs). And it's not mangling the whitespaces, or so I hope :-)

Tony

Re: [PATCH 2.6.18-rc1 1/1] arch/x86-64: A few trivial spelling and grammar fixes

[Randy.Dunlap]

On Mon, 10 Jul 2006 21:02:59 +0800 Antonino A. Daplas wrote:

> Arjan van de Ven wrote:
> >> Apologies Andi, white-space munging is probably the fault of gmail,
> >> despite using plain text only, I'll try and use Thunderbird from now
> >> on.
> > 
> > DOOOOOM
> > 
> > 
> > please read
> > 
> > http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
> > 
> > before thinking that thunderbird is better than gmail ;-)
> 
> It's not that hopeless, I use thunderbird + gmail + an external
> editor (emacs). And it's not mangling the whitespaces, or so I hope :-)

Right, tbird is usable (although could be much better).
I've done it and documented it several times.

---
~Randy

Re: [PATCH 2.6.18-rc1 1/1] arch/x86-64: A few trivial spelling and grammar fixes

[Antonino A. Daplas]

Randy.Dunlap wrote:
> On Mon, 10 Jul 2006 21:02:59 +0800 Antonino A. Daplas wrote:
> 
>> Arjan van de Ven wrote:
>>>> Apologies Andi, white-space munging is probably the fault of gmail,
>>>> despite using plain text only, I'll try and use Thunderbird from now
>>>> on.
>>> DOOOOOM
>>>
>>>
>>> please read
>>>
>>> http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
>>>
>>> before thinking that thunderbird is better than gmail ;-)
>> It's not that hopeless, I use thunderbird + gmail + an external
>> editor (emacs). And it's not mangling the whitespaces, or so I hope :-)
> 
> Right, tbird is usable (although could be much better).
> I've done it and documented it several times.
> 

Getting the external editor extension makes using tbird much
easier. When composing a message, just click on the external
editor icon and your favorite text editor pops up.

http://globs.org/?lng=en

Tony

Re: [PATCH 2.6.18-rc1 1/1] arch/x86-64: A few trivial spelling and grammar fixes

[Andi Kleen]

On Saturday 08 July 2006 19:27, Adam Henley wrote:
> A few trivial spelling and grammar mistakes picked up in
> "arch/x86_64/aperture.c", "arch/x86_64/crash.c" and
> "arch/x86_64/apic.c". I think all are correct fixes but am ever aware
> of my fallibility :o) This is my first patch submission so all
> feedback is appreciated, esp.

Applied thanks.

> WRT CCing to Linus, Andi and 
> trivial@kernel.org, is this correct? 

Me would have been enough in this case when there is an active maintainer.

> And which is the most appropriate 
> kernel version to diff against? If any.

2.6.18rc1 is fine

-Andi

Re: [PATCH 2.6.18-rc1 1/1] arch/x86-64: A few trivial spelling and grammar fixes

[Adrian Bunk]

On Mon, Jul 10, 2006 at 01:52:32AM +0200, Andi Kleen wrote:
> On Saturday 08 July 2006 19:27, Adam Henley wrote:
> > A few trivial spelling and grammar mistakes picked up in
> > "arch/x86_64/aperture.c", "arch/x86_64/crash.c" and
> > "arch/x86_64/apic.c". I think all are correct fixes but am ever aware
> > of my fallibility :o) This is my first patch submission so all
> > feedback is appreciated, esp.
> 
> Applied thanks.
> 
> > WRT CCing to Linus, Andi and 
> > trivial@kernel.org, is this correct? 
> 
> Me would have been enough in this case when there is an active maintainer.
>...

A Cc to trivial@kernel.org is never wrong for such patches - if a 
maintainer picks it up I'm simply deleting the patch.

> -Andi

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed