* [PATCH 2.6.18-rc1 1/1] mtd/maps: ixp4xx partition parsing
@ 2006-07-10 19:52 Brian Walsh
2006-07-10 20:02 ` Russell King
0 siblings, 1 reply; 4+ messages in thread
From: Brian Walsh @ 2006-07-10 19:52 UTC (permalink / raw)
To: Deepak Sanexa; +Cc: linux-kernel
If the amount of flash is not divisible by 2 then the mask in
parse_mtd_partitions would fail to work as designed. Passing in the
base address corrects this problem.
Signed-off-by: Brian Walsh <brian@walsh.ws>
---
diff -ur a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c
--- a/drivers/mtd/maps/ixp4xx.c 2006-06-17 21:49:35.000000000 -0400
+++ b/drivers/mtd/maps/ixp4xx.c 2006-07-10 13:34:09.000000000 -0400
@@ -253,7 +253,7 @@
/* Use the fast version */
info->map.write = ixp4xx_write16,
- err = parse_mtd_partitions(info->mtd, probes, &info->partitions, 0);
+ err = parse_mtd_partitions(info->mtd, probes, &info->partitions,
dev->resouce->start);
if (err > 0) {
err = add_mtd_partitions(info->mtd, info->partitions, err);
if(err)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2.6.18-rc1 1/1] mtd/maps: ixp4xx partition parsing
2006-07-10 19:52 [PATCH 2.6.18-rc1 1/1] mtd/maps: ixp4xx partition parsing Brian Walsh
@ 2006-07-10 20:02 ` Russell King
2006-07-10 20:40 ` Brian Walsh
2006-07-10 20:46 ` [PATCH 2.6.18-rc1 1/1] [RESUBMIT] " Brian Walsh
0 siblings, 2 replies; 4+ messages in thread
From: Russell King @ 2006-07-10 20:02 UTC (permalink / raw)
To: Brian Walsh; +Cc: Deepak Sanexa, linux-kernel
On Mon, Jul 10, 2006 at 03:52:27PM -0400, Brian Walsh wrote:
> If the amount of flash is not divisible by 2 then the mask in
> parse_mtd_partitions would fail to work as designed. Passing in the
> base address corrects this problem.
This patch is obviously buggy and untested. "resouce" is a typo.
> diff -ur a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c
> --- a/drivers/mtd/maps/ixp4xx.c 2006-06-17 21:49:35.000000000 -0400
> +++ b/drivers/mtd/maps/ixp4xx.c 2006-07-10 13:34:09.000000000 -0400
> @@ -253,7 +253,7 @@
> /* Use the fast version */
> info->map.write = ixp4xx_write16,
>
> - err = parse_mtd_partitions(info->mtd, probes, &info->partitions, 0);
> + err = parse_mtd_partitions(info->mtd, probes, &info->partitions,
> dev->resouce->start);
> if (err > 0) {
> err = add_mtd_partitions(info->mtd, info->partitions, err);
> if(err)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2.6.18-rc1 1/1] mtd/maps: ixp4xx partition parsing
2006-07-10 20:02 ` Russell King
@ 2006-07-10 20:40 ` Brian Walsh
2006-07-10 20:46 ` [PATCH 2.6.18-rc1 1/1] [RESUBMIT] " Brian Walsh
1 sibling, 0 replies; 4+ messages in thread
From: Brian Walsh @ 2006-07-10 20:40 UTC (permalink / raw)
To: Deepak Sanexa, linux-kernel
Russell King wrote:
> On Mon, Jul 10, 2006 at 03:52:27PM -0400, Brian Walsh wrote:
>
>> If the amount of flash is not divisible by 2 then the mask in
>> parse_mtd_partitions would fail to work as designed. Passing in the
>> base address corrects this problem.
>>
>
> This patch is obviously buggy and untested. "resouce" is a typo.
>
??
Strange, not sure how that 'r' got dropped. I will resubmit it corrected.
>
>> diff -ur a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c
>> --- a/drivers/mtd/maps/ixp4xx.c 2006-06-17 21:49:35.000000000 -0400
>> +++ b/drivers/mtd/maps/ixp4xx.c 2006-07-10 13:34:09.000000000 -0400
>> @@ -253,7 +253,7 @@
>> /* Use the fast version */
>> info->map.write = ixp4xx_write16,
>>
>> - err = parse_mtd_partitions(info->mtd, probes, &info->partitions, 0);
>> + err = parse_mtd_partitions(info->mtd, probes, &info->partitions,
>> dev->resouce->start);
>> if (err > 0) {
>> err = add_mtd_partitions(info->mtd, info->partitions, err);
>> if(err)
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 2.6.18-rc1 1/1] [RESUBMIT] mtd/maps: ixp4xx partition parsing
2006-07-10 20:02 ` Russell King
2006-07-10 20:40 ` Brian Walsh
@ 2006-07-10 20:46 ` Brian Walsh
1 sibling, 0 replies; 4+ messages in thread
From: Brian Walsh @ 2006-07-10 20:46 UTC (permalink / raw)
To: Deepak Sanexa, linux-kernel
If the amount of flash is not divisible by 2 then the mask in parse_mtd_partitions would fail to work as designed. Passing in the base address corrects this problem.
Signed-off-by: Brian Walsh <brian@walsh.ws>
---
diff -ur a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c
--- a/drivers/mtd/maps/ixp4xx.c 2006-06-17 21:49:35.000000000 -0400
+++ b/drivers/mtd/maps/ixp4xx.c 2006-07-10 16:29:47.000000000 -0400
@@ -253,7 +253,7 @@
/* Use the fast version */
info->map.write = ixp4xx_write16,
- err = parse_mtd_partitions(info->mtd, probes, &info->partitions, 0);
+ err = parse_mtd_partitions(info->mtd, probes, &info->partitions, dev->resource->start);
if (err > 0) {
err = add_mtd_partitions(info->mtd, info->partitions, err);
if(err)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-07-10 20:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-10 19:52 [PATCH 2.6.18-rc1 1/1] mtd/maps: ixp4xx partition parsing Brian Walsh
2006-07-10 20:02 ` Russell King
2006-07-10 20:40 ` Brian Walsh
2006-07-10 20:46 ` [PATCH 2.6.18-rc1 1/1] [RESUBMIT] " Brian Walsh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox