From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422813AbWGJUi7 (ORCPT ); Mon, 10 Jul 2006 16:38:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422815AbWGJUi7 (ORCPT ); Mon, 10 Jul 2006 16:38:59 -0400 Received: from mta10.adelphia.net ([68.168.78.202]:13445 "EHLO mta10.adelphia.net") by vger.kernel.org with ESMTP id S1422813AbWGJUi5 (ORCPT ); Mon, 10 Jul 2006 16:38:57 -0400 Message-ID: <44B2BB2C.7040607@walsh.ws> Date: Mon, 10 Jul 2006 16:40:12 -0400 From: Brian Walsh User-Agent: Mail/News 1.5 (X11/20060213) MIME-Version: 1.0 To: Deepak Sanexa , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.18-rc1 1/1] mtd/maps: ixp4xx partition parsing References: <44B2AFFB.2070507@walsh.ws> <20060710200212.GA31761@flint.arm.linux.org.uk> In-Reply-To: <20060710200212.GA31761@flint.arm.linux.org.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Russell King wrote: > On Mon, Jul 10, 2006 at 03:52:27PM -0400, Brian Walsh wrote: > >> If the amount of flash is not divisible by 2 then the mask in >> parse_mtd_partitions would fail to work as designed. Passing in the >> base address corrects this problem. >> > > This patch is obviously buggy and untested. "resouce" is a typo. > ?? Strange, not sure how that 'r' got dropped. I will resubmit it corrected. > >> diff -ur a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c >> --- a/drivers/mtd/maps/ixp4xx.c 2006-06-17 21:49:35.000000000 -0400 >> +++ b/drivers/mtd/maps/ixp4xx.c 2006-07-10 13:34:09.000000000 -0400 >> @@ -253,7 +253,7 @@ >> /* Use the fast version */ >> info->map.write = ixp4xx_write16, >> >> - err = parse_mtd_partitions(info->mtd, probes, &info->partitions, 0); >> + err = parse_mtd_partitions(info->mtd, probes, &info->partitions, >> dev->resouce->start); >> if (err > 0) { >> err = add_mtd_partitions(info->mtd, info->partitions, err); >> if(err) >> > >