From: Brian Walsh <brian@walsh.ws>
To: Deepak Sanexa <dsanexa@mvista.com>, linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.18-rc1 1/1] [RESUBMIT] mtd/maps: ixp4xx partition parsing
Date: Mon, 10 Jul 2006 16:46:34 -0400 [thread overview]
Message-ID: <44B2BCAA.5000007@walsh.ws> (raw)
In-Reply-To: <20060710200212.GA31761@flint.arm.linux.org.uk>
If the amount of flash is not divisible by 2 then the mask in parse_mtd_partitions would fail to work as designed. Passing in the base address corrects this problem.
Signed-off-by: Brian Walsh <brian@walsh.ws>
---
diff -ur a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c
--- a/drivers/mtd/maps/ixp4xx.c 2006-06-17 21:49:35.000000000 -0400
+++ b/drivers/mtd/maps/ixp4xx.c 2006-07-10 16:29:47.000000000 -0400
@@ -253,7 +253,7 @@
/* Use the fast version */
info->map.write = ixp4xx_write16,
- err = parse_mtd_partitions(info->mtd, probes, &info->partitions, 0);
+ err = parse_mtd_partitions(info->mtd, probes, &info->partitions, dev->resource->start);
if (err > 0) {
err = add_mtd_partitions(info->mtd, info->partitions, err);
if(err)
prev parent reply other threads:[~2006-07-10 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 19:52 [PATCH 2.6.18-rc1 1/1] mtd/maps: ixp4xx partition parsing Brian Walsh
2006-07-10 20:02 ` Russell King
2006-07-10 20:40 ` Brian Walsh
2006-07-10 20:46 ` Brian Walsh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B2BCAA.5000007@walsh.ws \
--to=brian@walsh.ws \
--cc=dsanexa@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox