From: Michael Tokarev <mjt@tls.msk.ru>
To: linux-kernel@vger.kernel.org
Subject: Re: functions returning 0 on success [was: [PATCH] Fix a memory leak in the i386 setup code]
Date: Tue, 11 Jul 2006 02:49:19 +0400 [thread overview]
Message-ID: <44B2D96F.8080405@tls.msk.ru> (raw)
In-Reply-To: <44B2D893.9050209@tls.msk.ru>
Michael Tokarev wrote:
[]
> Ofcourse, later you understand that do_something() returns 0
> on failure, and the code is correct. But the first impression
> (again, for me anyway) is that it's wrong.
>
> In such cases when a routine returns 0 on error, I usually write
> it this way:
....
s/error/success/g. Blah ;)
>
> if (request_resource() != 0)
> fail()
[..]
/mjt
next prev parent reply other threads:[~2006-07-10 22:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 22:13 [PATCH] Fix a memory leak in the i386 setup code Catalin Marinas
2006-07-10 22:25 ` Rafael J. Wysocki
2006-07-11 7:47 ` Catalin Marinas
2006-07-11 8:26 ` Rafael J. Wysocki
2006-07-10 22:45 ` functions returning 0 on success [was: [PATCH] Fix a memory leak in the i386 setup code] Michael Tokarev
2006-07-10 22:49 ` Michael Tokarev [this message]
2006-07-15 17:33 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B2D96F.8080405@tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox