public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Brad Campbell <brad@wasp.net.au>
To: Pavel Machek <pavel@ucw.cz>
Cc: suspend2-devel@lists.suspend2.net, lkml <linux-kernel@vger.kernel.org>
Subject: Re: /dev/rtc not suspending/resuming properly
Date: Tue, 11 Jul 2006 11:57:43 +0400	[thread overview]
Message-ID: <44B359F7.3050500@wasp.net.au> (raw)
In-Reply-To: <20060710223629.GA7443@elf.ucw.cz>

Pavel Machek wrote:

>> I've had a pretty good look at drivers/char/rtc.c and I can't see anywhere 
>> it would actually suspend/resume in the code, and investigation shows it 
>> does not appear to re-init the hardware on resume.
> 
> Well, you probably need to write suspend/resume support for it...

So it would seem..

I know absolutely nothing about the driver model (let alone C or kernel voodo in general) and have 
been investigating Documentation/driver-model. Would I be close if I were to suggest this needs to 
be a platform_driver? I'll certainly have a crack at it if I'm on the right track.

I've been having a look at some of the other drivers that use platform_driver however I'm a bit 
stumped at how I go about iterating through the various sparc buses using the platform_driver 
resource allocation functions.

#ifdef __sparc__
         struct linux_ebus *ebus;
         struct linux_ebus_device *edev;
#ifdef __sparc_v9__
         struct sparc_isa_bridge *isa_br;
         struct sparc_isa_device *isa_dev;
#endif
#endif

Or, do I just dodgy it up as the rtc is a legacy device, and leave the probe/allocation code alone 
and just add the pm stuff?

Brad
-- 
"Human beings, who are almost unique in having the ability
to learn from the experience of others, are also remarkable
for their apparent disinclination to do so." -- Douglas Adams

  reply	other threads:[~2006-07-11  7:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-10 12:49 /dev/rtc not suspending/resuming properly Brad Campbell
2006-07-10 22:36 ` Pavel Machek
2006-07-11  7:57   ` Brad Campbell [this message]
2006-07-11 11:18     ` Pavel Machek
2006-07-11 11:31       ` Brad Campbell
2006-07-11 11:33         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44B359F7.3050500@wasp.net.au \
    --to=brad@wasp.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=suspend2-devel@lists.suspend2.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox