public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: Linux kernel <linux-kernel@vger.kernel.org>
Subject: [ patch -mm1 00/02 ] scx200_gpio: use 1 cdev for N minors, not  N for N
Date: Tue, 11 Jul 2006 09:20:30 -0600	[thread overview]
Message-ID: <44B3C1BE.4080707@gmail.com> (raw)


this pair of patches switches the driver to share 1 cdev across N pins,
thus decreasing memory usage, and simplifying code ( no kzalloc, or its 
undo ).

Q:  For some reason I havent figured, the cdev_put below breaks:

static void __exit scx200_gpio_cleanup(void)
{
    cdev_del(&scx200_gpio_cdev);
    cdev_put(&scx200_gpio_cdev);    <<<<<<<<  HERE
   
    unregister_chrdev_region(MKDEV(major, 0), MAX_PINS);
    platform_device_unregister(pdev);
}

  CC [M]  drivers/char/scx200_gpio.o
Kernel: arch/i386/boot/bzImage is ready  (#6)
  Building modules, stage 2.
  MODPOST
WARNING: "cdev_put" [drivers/char/scx200_gpio.ko] undefined!
  LD [M]  drivers/char/scx200_gpio.ko


It seems odd that it isnt available, esp since cdev_init()
is also used wo errors ( in -mm1 currently ), and its defined in same
source-file: fs/char_dev.c

At any rate, I commented out the call in the 2nd patch and it works.
I left it to mark the question.


thanks
Jim Cromie

                 reply	other threads:[~2006-07-11 15:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44B3C1BE.4080707@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox