From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
rdunlap@xenotime.net, mreuther@umich.edu,
linux-kernel@vger.kernel.org, zap@homelink.ru
Subject: Re: [PATCH] fbdev: Statically link the framebuffer notification functions
Date: Tue, 11 Jul 2006 23:21:39 +0800 [thread overview]
Message-ID: <44B3C203.2010202@gmail.com> (raw)
In-Reply-To: <9e4733910607110803me340cbdg52b91933a6a2bbfe@mail.gmail.com>
Jon Smirl wrote:
> On 7/11/06, Antonino A. Daplas <adaplas@gmail.com> wrote:
>> > The code looks ok but this sure smells like inter_module_*.
>>
>> I assure you, there is no smell of inter_module_* here. What scenario
>> are you afraid of?
>
> Dangling references during the load/unload process. That was
> inter_module's problem.
That won't happen. If fbdev unloads, then the module that does the
notification disappears, and the clients won't receive notifications.
If the client is the one that unloads first, it unregisters its notifier
block, and that's one less client for fbdev to notify (And fbdev doesn't
know how many clients are there, that's internal to the notifier). And
since registration, unregistration and the call to the callout function
in the notifier block are protected by a semaphore (in the blocking type),
the danger of unregistration while in the midst of a notification is
removed.
Tony
next prev parent reply other threads:[~2006-07-11 15:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 12:32 Depmod errors on 2.6.17.4/2.6.18-rc1/2.6.18-rc1-mm1 Matt Reuther
2006-07-10 13:02 ` Antonino A. Daplas
2006-07-10 15:32 ` Matt Reuther
2006-07-10 15:58 ` Antonino A. Daplas
2006-07-11 3:27 ` Matt Reuther
2006-07-11 4:52 ` [PATCH] appledisplay/backlight (Depmod errors on 2.6.17.4/2.6.18-rc1/2.6.18-rc1-mm1) Randy.Dunlap
2006-07-11 6:54 ` [PATCH] backlight: lcd: Remove dependency from the framebuffer layer Antonino A. Daplas
2006-07-11 7:04 ` Antonino A. Daplas
2006-07-11 10:28 ` Andrew Morton
2006-07-11 10:36 ` Antonino A. Daplas
2006-07-11 12:45 ` [PATCH] fbdev: Statically link the framebuffer notification functions Antonino A. Daplas
2006-07-11 12:50 ` Antonino A. Daplas
2006-07-11 13:21 ` Jon Smirl
2006-07-11 13:40 ` Antonino A. Daplas
2006-07-11 13:46 ` Jon Smirl
2006-07-11 14:34 ` Antonino A. Daplas
2006-07-11 14:43 ` Jon Smirl
2006-07-11 14:50 ` Antonino A. Daplas
2006-07-11 15:03 ` Jon Smirl
2006-07-11 15:21 ` Antonino A. Daplas [this message]
2006-07-11 5:16 ` [PATCH] sound-miro unknown symbols (Depmod errors on 2.6.17.4/2.6.18-rc1/2.6.18-rc1-mm1) Randy.Dunlap
2006-07-11 6:56 ` Depmod errors on 2.6.17.4/2.6.18-rc1/2.6.18-rc1-mm1 Antonino A. Daplas
2006-07-11 11:20 ` Matt Reuther
2006-07-11 13:12 ` Antonino A. Daplas
2006-07-12 12:41 ` Matt Reuther
2006-07-12 15:25 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B3C203.2010202@gmail.com \
--to=adaplas@gmail.com \
--cc=akpm@osdl.org \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mreuther@umich.edu \
--cc=rdunlap@xenotime.net \
--cc=zap@homelink.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox