public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shailabh Nagar <nagar@watson.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Jay Lan <jlan@sgi.com>, Chris Sturtivant <csturtiv@sgi.com>,
	Paul Jackson <pj@sgi.com>, Balbir Singh <balbir@in.ibm.com>,
	Chandra Seetharaman <sekharan@us.ibm.com>
Subject: Re: [Patch 0/6] delay accounting & taskstats fixes
Date: Tue, 11 Jul 2006 11:33:42 -0400	[thread overview]
Message-ID: <44B3C4D6.8010606@watson.ibm.com> (raw)
In-Reply-To: <20060711112835.GA22832@infradead.org>

Christoph Hellwig wrote:
> On Tue, Jul 11, 2006 at 12:23:58AM -0400, Shailabh Nagar wrote:
> 
>>Andrew,
>>
>>Chandra, Balbir & I have been putting taskstats and delay accounting
>>patches through some extensive testing on multiple platforms.
>>
>>Following are a set of patches that fix some bugs found as well as
>>some cleanups of the code. Some results showing the cpumask feature 
>>works as expected will follow separately.
> 
> 
> Btw, did you ever explain what this delay accounting code is useful for
> exactly?  

Yes.
Previous postings have explained the rationale,

http://www.uwsg.indiana.edu/hypermail/linux/kernel/0511.1/2275.html
http://www.uwsg.indiana.edu/hypermail/linux/kernel/0512.0/2152.html

lwn.net had a good summary as always,
http://lwn.net/Articles/173209/




> It's an awfull lot of code that doesn't seem to have a huge
> use.  

The delay accounting part of the code is quite small (just a few
lines of timestamping code place in core kernel code) and much of the
remaining size comes from the interface. Since the interface is designed
to be of generic use towards ANY per-task accounting needs, discussions and
code have been fairly involved. We went through a long discussion of
potential exploiters:

(see thread under [Patch 0/8] per-task delay accounting at
http://www.uwsg.indiana.edu/hypermail/linux/kernel/0603.3/index.html

> While we're at it do you have a pointer to the associated userspace code?
> 

Its part of the patches in Documentation/accounting/getdelays.c

and the last-but-one version of it can be viewed at its location in the -mm
tree:
http://www.linux-m32r.org/lxr/http/source/Documentation/accounting/?a=generic

(The just accepted patches updates the documentation especially the parts
relating to cpumasks but the above should also suffice to give a flavor of
what userspace could do).


Thanks,
Shailabh


      reply	other threads:[~2006-07-11 15:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-11  4:23 [Patch 0/6] delay accounting & taskstats fixes Shailabh Nagar
2006-07-11  4:27 ` [Patch 1/6] per task delay accounting taskstats interface: code cleanup Shailabh Nagar
2006-07-11  4:29 ` [Patch 2/6] per task delay accounting taskstats interface: documentation fix Shailabh Nagar
2006-07-11  4:30 ` [Patch 3/6] per task delay accounting taskstats interface: fix early sem init Shailabh Nagar
2006-07-11  4:33 ` [Patch 4/6] per task delay accounting taskstats interface: fix drop listener only on socket close Shailabh Nagar
2006-07-11  4:34 ` [Patch 5/6] list_islast utility Shailabh Nagar
2006-07-11  4:36 ` [Patch 6/6] per task delay accounting taskstats interface: fix clone skbs for each listener Shailabh Nagar
2006-07-11 10:05   ` Andrew Morton
2006-07-11 10:28     ` Herbert Xu
2006-07-11 10:57       ` Andrew Morton
2006-07-11 11:15         ` Herbert Xu
2006-07-11 17:44           ` Shailabh Nagar
2006-07-12  5:41           ` Shailabh Nagar
2006-07-11  4:50 ` [Patch 0/6] delay accounting & taskstats fixes Shailabh Nagar
2006-07-11 11:28 ` Christoph Hellwig
2006-07-11 15:33   ` Shailabh Nagar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44B3C4D6.8010606@watson.ibm.com \
    --to=nagar@watson.ibm.com \
    --cc=akpm@osdl.org \
    --cc=balbir@in.ibm.com \
    --cc=csturtiv@sgi.com \
    --cc=hch@infradead.org \
    --cc=jlan@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pj@sgi.com \
    --cc=sekharan@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox