[PATCH] net48xx LED cleanups

[PATCH] net48xx LED cleanups

[Chris Boot]

Add the DRVNAME define to remove the two separate references of the driver name 
by string, and move the .driver.owner into the existing .driver sub-structure 
(or whatever it's called).

Signed-off-by: Chris Boot <bootc@bootc.net>

diff --git a/drivers/leds/leds-net48xx.c b/drivers/leds/leds-net48xx.c
index 35ee52f..713c4a8 100644
--- a/drivers/leds/leds-net48xx.c
+++ b/drivers/leds/leds-net48xx.c
@@ -18,6 +18,7 @@
  #include <asm/io.h>
  #include <linux/scx200_gpio.h>

+#define DRVNAME "net48xx-led"
  #define NET48XX_ERROR_LED_GPIO	20

  static struct platform_device *pdev;
@@ -66,13 +67,13 @@ static int net48xx_led_remove(struct pla
  }

  static struct platform_driver net48xx_led_driver = {
-	.driver.owner	= THIS_MODULE,
  	.probe		= net48xx_led_probe,
  	.remove		= net48xx_led_remove,
  	.suspend	= net48xx_led_suspend,
  	.resume		= net48xx_led_resume,
  	.driver		= {
-		.name = "net48xx-led",
+		.name		= DRVNAME,
+		.owner		= THIS_MODULE,
  	},
  };

@@ -89,7 +90,7 @@ static int __init net48xx_led_init(void)
  	if (ret < 0)
  		goto out;

-	pdev = platform_device_register_simple("net48xx-led", -1, NULL, 0);
+	pdev = platform_device_register_simple(DRVNAME, -1, NULL, 0);
  	if (IS_ERR(pdev)) {
  		ret = PTR_ERR(pdev);
  		platform_driver_unregister(&net48xx_led_driver);

-- 
Chris Boot
bootc@bootc.net
http://www.bootc.net/

Re: [PATCH] net48xx LED cleanups

[Chris Boot]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Chris Boot wrote:
> Add the DRVNAME define to remove the two separate references of the 
> driver name by string, and move the .driver.owner into the existing 
> .driver sub-structure (or whatever it's called).
> 
> Signed-off-by: Chris Boot <bootc@bootc.net>

Never trust Thunderbird. Attached.

-- 
Chris Boot
bootc@bootc.net
http://www.bootc.net/

[-- Attachment #2: net48xx-led-cleanup.patch --]
[-- Type: text/x-patch, Size: 1050 bytes --]

diff --git a/drivers/leds/leds-net48xx.c b/drivers/leds/leds-net48xx.c
index 35ee52f..713c4a8 100644
--- a/drivers/leds/leds-net48xx.c
+++ b/drivers/leds/leds-net48xx.c
@@ -18,6 +18,7 @@
 #include <asm/io.h>
 #include <linux/scx200_gpio.h>
 
+#define DRVNAME "net48xx-led"
 #define NET48XX_ERROR_LED_GPIO	20
 
 static struct platform_device *pdev;
@@ -66,13 +67,13 @@ static int net48xx_led_remove(struct pla
 }
 
 static struct platform_driver net48xx_led_driver = {
-	.driver.owner	= THIS_MODULE,
 	.probe		= net48xx_led_probe,
 	.remove		= net48xx_led_remove,
 	.suspend	= net48xx_led_suspend,
 	.resume		= net48xx_led_resume,
 	.driver		= {
-		.name = "net48xx-led",
+		.name		= DRVNAME,
+		.owner		= THIS_MODULE,
 	},
 };
 
@@ -89,7 +90,7 @@ static int __init net48xx_led_init(void)
 	if (ret < 0)
 		goto out;
 
-	pdev = platform_device_register_simple("net48xx-led", -1, NULL, 0);
+	pdev = platform_device_register_simple(DRVNAME, -1, NULL, 0);
 	if (IS_ERR(pdev)) {
 		ret = PTR_ERR(pdev);
 		platform_driver_unregister(&net48xx_led_driver);