public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Fulghum <paulkf@microgate.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jon Smirl <jonsmirl@gmail.com>, Theodore Tso <tytso@mit.edu>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: tty's use of file_list_lock and file_move
Date: Tue, 11 Jul 2006 18:28:09 -0500	[thread overview]
Message-ID: <44B43409.2020401@microgate.com> (raw)
In-Reply-To: <1152657465.18028.72.camel@localhost.localdomain>

Alan Cox wrote:
> Ar Maw, 2006-07-11 am 18:08 -0400, ysgrifennodd Jon Smirl:
> 
>>What about adjusting things so the BKL isn't required? I tried
>>completely removing it and died in release_dev. tty_mutex is already
>>locks a lot of stuff, maybe it can be adjusted to allow removal of the
>>BKL.
> 
> 
> Thats what is happening currently. However it is being done piece by
> piece, slowly and carefully.

I hate to chime in since I don't have time in the near term
to contribute to the subject, but I do like the idea of removing
the BKL dependence as a first step. I find its semantics akward to keep
track of, and error prone. More explicit locking, even global, would clear things
up for a later push to finer grained (per tty?) locking (where appropriate).

Making the necessary changes to all the individual drivers,
as Russel's comment about explicitly dropping the new lock when
sleeping pointed out, would be a time consuming (and probably
tedious) task.

--
Paul


  reply	other threads:[~2006-07-11 23:28 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-10 15:10 tty's use of file_list_lock and file_move Jon Smirl
2006-07-10 17:33 ` Alan Cox
2006-07-10 17:27   ` Jon Smirl
2006-07-10 18:05     ` Alan Cox
2006-07-10 18:09       ` Jon Smirl
2006-07-10 23:18         ` Alan Cox
2006-07-10 22:35       ` Jon Smirl
2006-07-10 23:15         ` Alan Cox
2006-07-10 23:04           ` Jon Smirl
2006-07-10 23:49             ` Jon Smirl
2006-07-11  1:29               ` Theodore Tso
2006-07-11  2:16                 ` Jon Smirl
2006-07-11 10:12                   ` Alan Cox
2006-07-11 12:28                     ` Jon Smirl
2006-07-11 13:15                       ` Paulo Marques
2006-07-11 13:42                         ` Jon Smirl
2006-07-11  3:33                 ` Jon Smirl
2006-07-11 19:52                   ` Russell King
2006-07-11 19:44                 ` Russell King
2006-07-11 22:08                   ` Jon Smirl
2006-07-11 22:37                     ` Alan Cox
2006-07-11 23:28                       ` Paul Fulghum [this message]
2006-07-12  0:00                         ` Jon Smirl
2006-07-11 23:50                       ` Jon Smirl
2006-07-12  3:55                         ` Jon Smirl
2006-07-12 11:37                         ` Alan Cox
2006-07-10 23:39         ` Theodore Tso
2006-07-11  0:25           ` Jon Smirl
2006-07-12  6:27           ` Pekka Enberg
2006-07-12 11:19             ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44B43409.2020401@microgate.com \
    --to=paulkf@microgate.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jonsmirl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox