[GIT *] Remove inclusion of obsolete <linux/config.h>

[GIT *] Remove inclusion of obsolete <linux/config.h>

[David Woodhouse]

Linus, please pull from git://git.infradead.org/~dwmw2/killconfig.h.git

This removes all inclusion of the obsolete <linux/config.h> and turns
that file into a simple #error. I chose to add #error rather than just
deleting the file, to make the error message more informative and
hopefully prevent too many people from asking "where did config.h go?".

Sam thinks it should be a #warning instead, even though it's been
unnecessary to include config.h for about eight months now. If you
agree, pull from git://git.infradead.org/~dwmw2/woundconfig.h.git
instead -- that differs from the first in that it turns config.h into a
#warning instead.

Please pull one or the other, as you see fit.

-- 
dwmw2

Re: [GIT *] Remove inclusion of obsolete <linux/config.h>

[Petr Vandrovec]

David Woodhouse wrote:
> Linus, please pull from git://git.infradead.org/~dwmw2/killconfig.h.git

> Sam thinks it should be a #warning instead, even though it's been
> unnecessary to include config.h for about eight months now. If you
> agree, pull from git://git.infradead.org/~dwmw2/woundconfig.h.git
> instead -- that differs from the first in that it turns config.h into a
> #warning instead.

Well, it is probably unnecessary to include config.h for about eight months, but 
as it is not present in feature-removal-schedule.txt I've missed it.  Thanks for 
pointing it out...

FYI, fortunately (for you, unfortunately for VMware) 2.6.18's already broke our 
build script due to UTS_RELEASE being moved to separate file, so from VMware's 
viewpoint killconfig.h.git will not do any additional damage...

> Please pull one or the other, as you see fit.

								Petr Vandrovec

Re: [GIT *] Remove inclusion of obsolete <linux/config.h>

[Sam Ravnborg]

> Well, it is probably unnecessary to include config.h for about eight 
> months, but as it is not present in feature-removal-schedule.txt I've 
> missed it.  Thanks for pointing it out...
Obsoleting a header is not a "feature-removal" per se.

> FYI, fortunately (for you, unfortunately for VMware) 2.6.18's already broke 
> our build script due to UTS_RELEASE being moved to separate file, so from 
> VMware's viewpoint killconfig.h.git will not do any additional damage...
#include <linux/config.h>
#ifndef UTS_RELEASE
#include <linux/utsrelease.h>
#endif

Then one can wonder why WMware needs UTS_RELEASE?

	Sam

Re: [GIT *] Remove inclusion of obsolete <linux/config.h>

[Petr Vandrovec]

Sam Ravnborg wrote:
>>FYI, fortunately (for you, unfortunately for VMware) 2.6.18's already broke 
>>our build script due to UTS_RELEASE being moved to separate file, so from 
>>VMware's viewpoint killconfig.h.git will not do any additional damage...
> 
> #include <linux/config.h>
> #ifndef UTS_RELEASE
> #include <linux/utsrelease.h>
> #endif
> 
> Then one can wonder why WMware needs UTS_RELEASE?

To make sure user is building modules for kernel it is really using.  Without
this test users were building modules for kernels they have run years ago, and
then complained that modules do not fit to running kernel, or that kernel
crashes when they do 'insmod -f ...'...  So perl wrapper passes linux/version.h
through C preprocessor and compares resulting UTS_RELEASE with `uname -r`, and
complains loudly if they do not match.
								Petr

Re: [GIT *] Remove inclusion of obsolete <linux/config.h>

[Arjan van de Ven]

On Wed, 2006-07-12 at 13:00 +0200, Petr Vandrovec wrote:
> Sam Ravnborg wrote:
> >>FYI, fortunately (for you, unfortunately for VMware) 2.6.18's already broke 
> >>our build script due to UTS_RELEASE being moved to separate file, so from 
> >>VMware's viewpoint killconfig.h.git will not do any additional damage...
> > 
> > #include <linux/config.h>
> > #ifndef UTS_RELEASE
> > #include <linux/utsrelease.h>
> > #endif
> > 
> > Then one can wonder why WMware needs UTS_RELEASE?
> 
> To make sure user is building modules for kernel it is really using.  Without
> this test users were building modules for kernels they have run years ago, and
> then complained that modules do not fit to running kernel, or that kernel
> crashes when they do 'insmod -f ...'...  So perl wrapper passes linux/version.h
> through C preprocessor and compares resulting UTS_RELEASE with `uname -r`, and
> complains loudly if they do not match.
> 					

isn't this exactly what VERMAGIC is for instead?

Re: [GIT *] Remove inclusion of obsolete <linux/config.h>

[Petr Vandrovec]

Arjan van de Ven wrote:
> On Wed, 2006-07-12 at 13:00 +0200, Petr Vandrovec wrote:
> 
>>Sam Ravnborg wrote:
>>
>>To make sure user is building modules for kernel it is really using.  Without
>>this test users were building modules for kernels they have run years ago, and
>>then complained that modules do not fit to running kernel, or that kernel
>>crashes when they do 'insmod -f ...'...  So perl wrapper passes linux/version.h
>>through C preprocessor and compares resulting UTS_RELEASE with `uname -r`, and
>>complains loudly if they do not match.
> 
> isn't this exactly what VERMAGIC is for instead?

In newer kernels only.  We still support 2.2.x kernels, and to find kernel version
you have to parse some kernel headers...  And unfortunately vermagic mismatch is
printed into `dmesg` only, so it takes several iterations until customer is able
to pinpoint problem down (to 586/686 mismatch, for example).
								Petr

[GIT *] Remove inclusion of obsolete <linux/config.h>

[David Woodhouse]

Linus, please pull from git://git.infradead.org/~dwmw2/killconfig.h.git

This contains two commits. The first removes all inclusions of
<linux/config.h> from the kernel sources, and the second turns
include/linux/config.h into a one-line #error.

I chose to add #error rather than just deleting the file, to make the
error message more informative and hopefully prevent too many people
from asking "where did config.h go?".

Sam thinks it should be a #warning instead, even though it's been
unnecessary to include config.h for about eight months now. If you
agree, pull from git://git.infradead.org/~dwmw2/woundconfig.h.git
instead -- that contains the same first commit and then the second
commit creates a #warning instead.

Please pull one or the other.

-- 
dwmw2

Re: [GIT *] Remove inclusion of obsolete <linux/config.h>

[David Woodhouse]

On Thu, 2006-07-06 at 14:07 +0100, David Woodhouse wrote:
> Linus, please pull from git://git.infradead.org/~dwmw2/killconfig.h.git
> 
> This contains two commits. The first removes all inclusions of
> <linux/config.h> from the kernel sources, and the second turns
> include/linux/config.h into a one-line #error.

Btw, Andrew...

hera /pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm6/broken-out $ grep "+#include <linux/config.h>" * -l
acx1xx-wireless-driver.patch
apple-motion-sensor-driver.patch
edac-new-opteron-athlon64-memory-controller-driver.patch
git-ia64.patch
git-klibc.patch
git-sas.patch
git-watchdog.patch
gregkh-usb-usb-gotemp.patch
gregkh-usb-usb-serial-mos7720.patch
mutex-subsystem-synchro-test-module.patch
origin.patch
reiser4.patch
touchkit-ps-2-touchscreen-driver.patch


-- 
dwmw2

Re: [GIT *] Remove inclusion of obsolete <linux/config.h>

[Greg KH]

On Thu, Jul 06, 2006 at 02:11:22PM +0100, David Woodhouse wrote:
> gregkh-usb-usb-gotemp.patch
> gregkh-usb-usb-serial-mos7720.patch

I'll fix these two, they should not have had that #include at all...

thanks,

greg k-h