Re: [PATCH -mm 5/7] add user namespace

Serge E. Hallyn
2006-07-14T17:09:18Z

Quoting Dave Hansen (haveblue@us.ibm.com):
> On Fri, 2006-07-14 at 10:49 -0600, Eric W. Biederman wrote:
> > - if (current->fsuid == inode->i_uid)
> > + if ((current->fsuid == inode->i_uid) &&
> > + (current->nsproxy->user_ns == inode->i_sb->user_ns))
> > mode >>= 6;
>
> I really don't think assigning a user namespace to a superblock is the
> right way to go. Seems to me like the _view_ into the filesystem is
> what you want to modify. That would seem to me to mean that each
> 'struct namespace' (filesystem namespace) or vfsmount would be assigned
> a corresponding user namespace, *not* the superblock.

yes, of course, vfsmount, which I assume is what Eric meant?

Which means we'd have to do this at permission() using the nameidata, or
pass nd to generic_permission.

-serge