Re: [PATCH -mm 5/7] add user namespace

Eric W. Biederman
2006-07-13T19:56:10Z

Dave Hansen <haveblue@us.ibm.com> writes:

> On Thu, 2006-07-13 at 12:21 -0600, Eric W. Biederman wrote:
>> We need a formula for doing incremental development that will allow us to
>> make headway while not seeing the entire picture all at once. The scope
>> is just too large.
>
> Definitely. We need a low-risk development environment where we can put
> test-fit pieces together, but also not worry too much of we have to rip
> pieces out, or completely change them.

It probably makes sense to talk about this up in Ottowa.

> I'm not sure we *need* to rewrite things for review-ability later. I
> think some of us have gotten pretty good at keeping our development in
> reviewable bits as we go along.

Well the rewrite of the history may simply be an ordering change.

It isn't so much the reviewability of a single piece but the reviewability
of the whole that I am worried about. I have had one occasion lately
where I made a small simple sane change but I discovered that there
was one little hack I had to get rid of to make everything work.

To remove that hack required me to refactor another piece of code and
was more work than the original change. That refactoring then had to happen
first, when the code was merged with the rest of the kernel.

So while we should try to keep our pieces as sane as possible we should
assume we have to rewrite history from our sandbox when we push the code
upstream.

Eric