From: Jeff Mahoney <jeffm@suse.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: ReiserFS List <reiserfs-list@namesys.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] reiserfs: fix handling of device names with /'s in them
Date: Wed, 12 Jul 2006 13:02:56 -0400 [thread overview]
Message-ID: <44B52B40.3020704@suse.com> (raw)
In-Reply-To: <200607121857.45988.dada1@cosmosbay.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Eric Dumazet wrote:
> On Wednesday 12 July 2006 18:42, Jeff Mahoney wrote:
>> On systems with block devices containing slashes (virtual dasd, cciss,
>> etc), reiserfs will fail to initialize /proc/fs/reiserfs/<dev> due to
>> it being interpreted as a subdirectory. The generic block device code
>> changes the / to ! for use in the sysfs tree. This patch uses that
>> convention.
>>
>> Tested by making dm devices use dm/<number> rather than dm-<number>
>
> Your patch handles at most one slash. But the description mentions 'slashes'
> (ie several slashes)
>
>> + if (s)
>> + *s = '!';
>
> Maybe you need a loop
I'd prefer to correct the grammar rather than the patch. This patch
simply duplicates the logic in make_block_name().
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFEtStALPWxlyuTD7IRAgl0AJ9Q25r0SIZpIZrX/m6ld69OLwvoxQCfdRj/
XIT1LYuQThoypHAx7ud96h8=
=0ZdG
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2006-07-12 17:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 16:42 [PATCH] reiserfs: fix handling of device names with /'s in them Jeff Mahoney
2006-07-12 16:57 ` Eric Dumazet
2006-07-12 17:02 ` Jeff Mahoney [this message]
2006-07-13 0:55 ` Andrew Morton
2006-07-13 3:51 ` Hans Reiser
2006-07-13 4:00 ` Andrew Morton
2006-07-13 7:34 ` Hans Reiser
2006-07-13 5:23 ` H. Peter Anvin
[not found] <6xQ4C-6NB-43@gated-at.bofh.it>
[not found] ` <6xQea-6ZX-13@gated-at.bofh.it>
2006-07-14 16:10 ` Bodo Eggert
2006-07-14 17:50 ` Jeff Mahoney
2006-07-16 7:12 ` Hans Reiser
2006-07-16 15:56 ` Jeffrey Mahoney
2006-07-16 18:14 ` Hans Reiser
2006-07-16 22:17 ` Jeff Mahoney
2006-07-17 1:21 ` Hans Reiser
2006-07-17 1:50 ` Jeffrey Mahoney
2006-07-17 3:02 ` Hans Reiser
2006-07-17 3:17 ` Jeffrey Mahoney
2006-07-17 7:29 ` Hans Reiser
2006-07-17 14:55 ` Jeff Mahoney
2006-07-17 18:19 ` Hans Reiser
2006-07-17 18:38 ` Jeff Mahoney
2006-07-17 19:07 ` Hans Reiser
2006-07-17 19:59 ` Jeff Mahoney
2006-07-17 21:03 ` Hans Reiser
2006-07-17 22:26 ` Rudy Zijlstra
2006-07-18 0:26 ` Horst von Brand
2006-07-18 16:38 ` Jan Engelhardt
2006-07-17 18:08 ` Valdis.Kletnieks
2006-07-17 18:16 ` Jeff Mahoney
2006-07-17 18:53 ` Hans Reiser
2006-07-17 19:07 ` Jeff Mahoney
2006-07-17 18:27 ` Hans Reiser
2006-07-17 19:52 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B52B40.3020704@suse.com \
--to=jeffm@suse.com \
--cc=akpm@osdl.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-list@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox