public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	torvalds@osdl.org, Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH: Fix Jmicron support
Date: Wed, 12 Jul 2006 13:05:22 -0400	[thread overview]
Message-ID: <44B52BD2.2030004@pobox.com> (raw)
In-Reply-To: <1152713141.22943.67.camel@localhost.localdomain>

Alan Cox wrote:
> Prior to 2.6.18rc1 you could install with devices on a JMicron chipset
> using the "all-generic-ide" option. As of this kernel the AHCI driver
> grabs the controller and rams it into AHCI mode losing the PATA ports
> and making CD drives and the like vanish. The all-generic-ide option
> fails because the AHCI driver grabbed the PCI device and reconfigured
> it.
> 
> To fix this three things are needed.
> 
> #1 We must put the chip into dual function mode
> #2 The AHCI driver must grab only function 0 (already in your rc1 tree)
> #3 Something must grab the PATA ports
> 
> The attached patch is the minimal risk edition of this. It puts the chip
> into dual function mode so that AHCI will grab the SATA ports without
> losing the PATA ports. To keep the risk as low as possible the third
> patch adds the PCI identifiers for the PATA port and the FN check to the
> ide-generic driver. There is a more featured jmicron driver on its way
> but that adds risk and the ide-generic support is sufficient to install
> and run a system.
> 
> The actual chip setup done by the quirk is the precise setup recommended
> by the vendor.
> 
> (The JMB368 appears only in the ide-generic entry as it has no AHCI so
> does not need the quirk)
> 
> Signed-off-by: Alan Cox <alan@redhat.com>

ACK for 2.6.18-rc1-git

The AHCI bits are already in 2.6.18-rc1.  The drivers/ide new-PCI-ID 
bits are arguably new features, but IMO obviously quite harmless.

	Jeff



      parent reply	other threads:[~2006-07-12 17:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-12 14:05 PATCH: Fix Jmicron support Alan Cox
2006-07-12 14:03 ` Olivier Galibert
2006-07-12 17:05 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44B52BD2.2030004@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox