public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: Linux kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: [ patch -mm1 02/03 ] gpio: cosmetics - remove needless newlines
Date: Wed, 12 Jul 2006 11:21:08 -0600	[thread overview]
Message-ID: <44B52F84.1090003@gmail.com> (raw)


2 - pure cosmetics - lose needless newlines.

3 - rename EXPORTed  gpio vtables  from {scx200,pc8736x}_access to  
_gpio_ops
new name is much closer to the vtable-name struct nsc_gpio_ops, should 
be clearer.
Also rename the _fops vtable var to _fileops to better disambiguate it 
from the gpio vtable.

Signed-off-by  Jim Cromie  <jim.cromie@gmail.com>

---

$ diffstat diff.cosmetic-1
 nsc_gpio.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)


diff -ruNp -X dontdiff -X exclude-diffs a0-nohilo/drivers/char/nsc_gpio.c a0-1-cosmetic/drivers/char/nsc_gpio.c
--- a0-nohilo/drivers/char/nsc_gpio.c	2006-07-12 09:18:19.000000000 -0600
+++ a0-1-cosmetic/drivers/char/nsc_gpio.c	2006-07-12 10:27:46.000000000 -0600
@@ -68,13 +68,11 @@ ssize_t nsc_gpio_write(struct file *file
 			amp->gpio_config(m, ~1, 0);
 			break;
 		case 'T':
-			dev_dbg(dev, "GPIO%d output is push pull\n",
-			       m);
+			dev_dbg(dev, "GPIO%d output is push pull\n", m);
 			amp->gpio_config(m, ~2, 2);
 			break;
 		case 't':
-			dev_dbg(dev, "GPIO%d output is open drain\n",
-			       m);
+			dev_dbg(dev, "GPIO%d output is open drain\n", m);
 			amp->gpio_config(m, ~2, 0);
 			break;
 		case 'P':



                 reply	other threads:[~2006-07-12 17:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44B52F84.1090003@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox