[PATCH 4/5] UML - Reenable SysRq support

[PATCH 4/5] UML - Reenable SysRq support

[Jeff Dike]

Sysrq works fine on UML.

Signed-off-by: Jeff Dike <jdike@addtoit.com>

Index: linux-2.6.17/lib/Kconfig.debug
===================================================================
--- linux-2.6.17.orig/lib/Kconfig.debug	2006-07-12 11:26:41.000000000 -0400
+++ linux-2.6.17/lib/Kconfig.debug	2006-07-12 11:33:02.000000000 -0400
@@ -18,7 +18,6 @@ config ENABLE_MUST_CHECK
 
 config MAGIC_SYSRQ
 	bool "Magic SysRq key"
-	depends on !UML
 	help
 	  If you say Y here, you will have some control over the system even
 	  if the system crashes for example during kernel debugging (e.g., you

Re: [uml-devel] [PATCH 4/5] UML - Reenable SysRq support

[Blaisorblade]

On Wednesday 12 July 2006 18:40, Jeff Dike wrote:
> Sysrq works fine on UML.
>
> Signed-off-by: Jeff Dike <jdike@addtoit.com>
>
> Index: linux-2.6.17/lib/Kconfig.debug
> ===================================================================
> --- linux-2.6.17.orig/lib/Kconfig.debug	2006-07-12 11:26:41.000000000 -0400
> +++ linux-2.6.17/lib/Kconfig.debug	2006-07-12 11:33:02.000000000 -0400
> @@ -18,7 +18,6 @@ config ENABLE_MUST_CHECK
>
>  config MAGIC_SYSRQ
>  	bool "Magic SysRq key"
> -	depends on !UML
>  	help
>  	  If you say Y here, you will have some control over the system even
>  	  if the system crashes for example during kernel debugging (e.g., you
Please reject this patch, the setting for UML is just elsewhere, in 
arch/um/Kconfig (and depends on MCONSOLE).

If kbuild doesn't handle well having an option declared twice now (it isn't 
very happy but it worked when I added the above dependency) we can rename the 
one in arch/um/Kconfig to MAGIC_SYSRQ_UML and make the one above like this 
(untested):

config MAGIC_SYSRQ
	bool
	prompt "Magic SysRq key" if !UML
	depends on MAGIC_SYSRQ_UML || !UML
	default y if UML

-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 

Re: [uml-devel] [PATCH 4/5] UML - Reenable SysRq support

[Jeff Dike]

On Wed, Jul 12, 2006 at 08:56:00PM +0200, Blaisorblade wrote:
> Please reject this patch, the setting for UML is just elsewhere, in 
> arch/um/Kconfig (and depends on MCONSOLE).

Whoops, right.

I swear I did a search on SYSRQ in menuconfig and the only thing that came
up was the lib/Kconfig.debug one.

I just checked, and it finds the arch/um one...

				Jeff

Re: [uml-devel] [PATCH 4/5] UML - Reenable SysRq support

[H. Peter Anvin]

Blaisorblade wrote:
> On Wednesday 12 July 2006 18:40, Jeff Dike wrote:
>> Sysrq works fine on UML.
>>
>> Signed-off-by: Jeff Dike <jdike@addtoit.com>
>>
>> Index: linux-2.6.17/lib/Kconfig.debug
>> ===================================================================
>> --- linux-2.6.17.orig/lib/Kconfig.debug	2006-07-12 11:26:41.000000000 -0400
>> +++ linux-2.6.17/lib/Kconfig.debug	2006-07-12 11:33:02.000000000 -0400
>> @@ -18,7 +18,6 @@ config ENABLE_MUST_CHECK
>>
>>  config MAGIC_SYSRQ
>>  	bool "Magic SysRq key"
>> -	depends on !UML
>>  	help
>>  	  If you say Y here, you will have some control over the system even
>>  	  if the system crashes for example during kernel debugging (e.g., you
> Please reject this patch, the setting for UML is just elsewhere, in 
> arch/um/Kconfig (and depends on MCONSOLE).
> 
> If kbuild doesn't handle well having an option declared twice now (it isn't 
> very happy but it worked when I added the above dependency) we can rename the 
> one in arch/um/Kconfig to MAGIC_SYSRQ_UML and make the one above like this 
> (untested):
> 
> config MAGIC_SYSRQ
> 	bool
> 	prompt "Magic SysRq key" if !UML
> 	depends on MAGIC_SYSRQ_UML || !UML
> 	default y if UML
> 

Why not:

config MAGIC_SYSRQ
	bool
	prompt "Magic SysRq key"
	depends on !UML || MCONSOLE
	default y if UML

	-hpa

Re: [uml-devel] [PATCH 4/5] UML - Reenable SysRq support

[Paolo Giarrusso]

"H. Peter Anvin" <hpa@zytor.com> ha scritto: 

> Why not:
> 
> config MAGIC_SYSRQ
> 	bool
> 	prompt "Magic SysRq key"
> 	depends on !UML || MCONSOLE
> 	default y if UML
> 
> 	-hpa

Because it has always been elsewhere in Kconfig (near MCONSOLE) for a
meaningful reason (it is used through mconsole) and nobody has
decided to move it.

Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com