Re: 2.6.18-rc1-git4 and 2.6.18-rc1-mm1 OOM's on boot

[Martin Bligh <mbligh@google.com>]

Andrew Morton wrote:
> On Wed, 12 Jul 2006 09:53:08 -0700
> Martin Bligh <mbligh@google.com> wrote:
> 
> 
>>-git3 was fine
>>(bootlog for git3: http://test.kernel.org/abat/40748/debug/console.log)
>>
>>-mm1 has the same issue
>>
>>Slightly different manifestations across 2 boots
>>
>>http://test.kernel.org/abat/40760/debug/console.log
>>http://test.kernel.org/abat/40837/debug/console.log
> 
> 
>  [<c0136fcf>] out_of_memory+0x29/0xf6
>  [<c0137f48>] __alloc_pages+0x1ed/0x276
>  [<c014db73>] kmem_getpages+0x63/0xc1
>  [<c014e960>] cache_grow+0xaa/0x139
>  [<c014eb6a>] cache_alloc_refill+0x17b/0x1c0
>  [<c014f1ef>] __kmalloc+0x83/0x93
>  [<c0168cf5>] alloc_fd_array+0x19/0x24
>  [<c0169122>] alloc_fdtable+0xb2/0xef
>  [<c016917f>] expand_fdtable+0x20/0x7d
>  [<c0169221>] expand_files+0x45/0x50
>  [<c0161263>] locate_fd+0x70/0x8e
>  [<c01612aa>] dupfd+0x29/0x61
>  [<c01613dc>] sys_dup+0x1b/0x23
>  [<c01027d3>] syscall_call+0x7/0xb
> 
> I suspect that's because I had me a little mistake.
> 
> --- a/fs/file.c~alloc_fdtable-expansion-fix
> +++ a/fs/file.c
> @@ -240,7 +240,7 @@ static struct fdtable *alloc_fdtable(int
>  	if (!fdt)
>    		goto out;
>  
> -	nfds = max_t(int, 8 * L1_CACHE_BYTES, roundup_pow_of_two(nfds));
> +	nfds = max_t(int, 8 * L1_CACHE_BYTES, roundup_pow_of_two(nr + 1));
>  	if (nfds > NR_OPEN)
>  		nfds = NR_OPEN;
>  
> _
> 

Thanks, that was affecting several machines.

Andy, any chance we can do an across-all-machines run of that one on top
of -mm1? Thanks,

M.