From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964874AbWGMJfg (ORCPT ); Thu, 13 Jul 2006 05:35:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964876AbWGMJfg (ORCPT ); Thu, 13 Jul 2006 05:35:36 -0400 Received: from 85.8.24.16.se.wasadata.net ([85.8.24.16]:28288 "EHLO smtp.drzeus.cx") by vger.kernel.org with ESMTP id S964874AbWGMJfg (ORCPT ); Thu, 13 Jul 2006 05:35:36 -0400 Message-ID: <44B613ED.4000809@drzeus.cx> Date: Thu, 13 Jul 2006 11:35:41 +0200 From: Pierre Ossman User-Agent: Thunderbird 1.5.0.4 (X11/20060613) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_hera.drzeus.cx-13285-1152783334-0001-2" To: Greg KH CC: LKML Subject: Re: resource_size_t and printk() References: <44AAD59E.7010206@drzeus.cx> <20060704214508.GA23607@kroah.com> <44AB3DF7.8080107@drzeus.cx> <20060711231537.GC18973@kroah.com> <44B4B041.9050808@drzeus.cx> <20060712213723.GB9049@kroah.com> In-Reply-To: <20060712213723.GB9049@kroah.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_hera.drzeus.cx-13285-1152783334-0001-2 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit Greg KH wrote: > Like Randy said, please use "unsigned long long". > > Care to redo this? > Here you go. --=_hera.drzeus.cx-13285-1152783334-0001-2 Content-Type: text/x-patch; name="pnp-fixprintk.patch"; charset=iso-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="pnp-fixprintk.patch" [PNP] Add missing casts in printk() arguments Some resource_size_t values are fed to printk() without handling the fact that they can have different size depending on your .config. Signed-off-by: Pierre Ossman --- drivers/pnp/interface.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pnp/interface.c b/drivers/pnp/interface.c index 3163e3d..9d8b415 100644 --- a/drivers/pnp/interface.c +++ b/drivers/pnp/interface.c @@ -265,8 +265,8 @@ static ssize_t pnp_show_current_resource pnp_printf(buffer," disabled\n"); else pnp_printf(buffer," 0x%llx-0x%llx\n", - pnp_port_start(dev, i), - pnp_port_end(dev, i)); + (unsigned long long)pnp_port_start(dev, i), + (unsigned long long)pnp_port_end(dev, i)); } } for (i = 0; i < PNP_MAX_MEM; i++) { @@ -276,8 +276,8 @@ static ssize_t pnp_show_current_resource pnp_printf(buffer," disabled\n"); else pnp_printf(buffer," 0x%llx-0x%llx\n", - pnp_mem_start(dev, i), - pnp_mem_end(dev, i)); + (unsigned long long)pnp_mem_start(dev, i), + (unsigned long long)pnp_mem_end(dev, i)); } } for (i = 0; i < PNP_MAX_IRQ; i++) { @@ -287,7 +287,7 @@ static ssize_t pnp_show_current_resource pnp_printf(buffer," disabled\n"); else pnp_printf(buffer," %lld\n", - pnp_irq(dev, i)); + (unsigned long long)pnp_irq(dev, i)); } } for (i = 0; i < PNP_MAX_DMA; i++) { @@ -297,7 +297,7 @@ static ssize_t pnp_show_current_resource pnp_printf(buffer," disabled\n"); else pnp_printf(buffer," %lld\n", - pnp_dma(dev, i)); + (unsigned long long)pnp_dma(dev, i)); } } ret = (buffer->curr - buf); --=_hera.drzeus.cx-13285-1152783334-0001-2--