Re: [PATCH 1/1] Fix boot on efi 32 bit Machines [try #4]

Linus Torvalds
2006-07-14T16:10:04Z

On Fri, 14 Jul 2006, Edgar Hucek wrote:
>
> This is the memory map from the efi shell :

Ok, it really looks like EFI is broken. You said that "ACPI_MCFG table
returns e0000000", ie we should find the config space thing there, yet:

> [ snip snip ... ]
> ACPI_recl 000000007EEEF000-000000007EEFEFFF 0000000000000010 000000000000000F
> RT_data 000000007EEFF000-000000007EEFFFFF 0000000000000001 800000000000000F
> MemMapIO 00000000E00F8000-00000000E00F8FFF 0000000000000001 8000000000000000
> MemMapIO 00000000FED1C000-00000000FED1FFFF 0000000000000004 8000000000000000
> MemMapIO 00000000FFFB0000-00000000FFFDFFFF 0000000000000030 8000000000000000

It clearly wasn't there..

However, it looks like your conversion is a bit buggy:

> This is the converted memory map :
>
> [ snip snip .. ]
> BIOS-EFI: 000000007eeef000 - 000000007eeff000 (ACPI data)
> BIOS-EFI: 00000000e00f8000 - 00000000e00f9000 (reserved)
> BIOS-EFI: 00000000fed1c000 - 00000000fed20000 (reserved)
> BIOS-EFI: 00000000fffb0000 - 00000000fffe0000 (reserved)

The above is missing the "RT_data" thing (which was there in your input):

mem31: type=6, attr=0x800000000000000f, range=[0x000000007eeff000-0x000000007ef00000) (0MB)

> This is the funktion i used for converting :
>
> case EFI_RESERVED_TYPE:
> case EFI_MEMORY_MAPPED_IO:
> case EFI_MEMORY_MAPPED_IO_PORT_SPACE:
> case EFI_UNUSABLE_MEMORY:
> add_memory_region(md->phys_addr, md->num_pages << EFI_PAGE_SHIFT, E820_RESERVED);
> break;

I think that should be a "default:", to make sure that you don't have any
memory region types that get ignored. Because it looks like you missed the
EFI_RUNTIME_SERVICES_CODE/EFI_RUNTIME_SERVICES_DATA ones at a minimum (an
dmaybe others - I didn't check).

Anyway, that won't fix your bug, and yes, it sounds like you should add a
PCI_PROBE_FORCE_MMCFG flag (and then do the proper MMIO region reservation
to make sure that we don't allocate over it when allocating PCI
resources).

Looks good otherwise.

Linus