Re: [PATCH -mm 5/7] add user namespace

Dave Hansen
2006-07-16T16:18:39Z

On Sat, 2006-07-15 at 17:29 -0600, Eric W. Biederman wrote:
> Trond Myklebust <trond.myklebust@fys.uio.no> writes:
> > You are still using the wrong abstraction. Data that is not global to
> > the entire machine has absolutely _no_ place being put into the
> > superblock. It doesn't matter if it is process-specific,
> > container-specific or whatever-else-specific, it will still be vetoed.
>
> Sure, I have no problem with only global data, and filesystem specific
> data being in a super block. In this case my impression is that the
> data is at least arguably filesystem specific. filesystem-specific
> data is ok on the super block is it not?

Yes, it is OK if you can win that argument. ;) I'll let you take that
one up with Al. You're just saying that since there is a possibility of
an argument, it should be OK to put the data in the sb?

I think the uid mapping properties are OK to keep in the superblock if
and only if there is only one possible way to interpret the uids on the
disk into the uids that are seen in userspace.

This is the same argument for putting things like mnt_root in the
vfsmount. Is there only one possible place in the filesystem in which a
given superblock may be mounted? No. So, it goes in the vfsmount.

I personally trust people like Trond's judgment on this stuff like this.
He's been messing with the VFS much longer than I. Eric, would you like
to start another thread on this topic, and CC the main people from this
thread, and include Al?

Or, is this something we should address briefly at the kernel summit?

-- Dave