public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Mahoney <jeffm@suse.com>
To: Hans Reiser <reiser@namesys.com>
Cc: 7eggert@gmx.de, Eric Dumazet <dada1@cosmosbay.com>,
	ReiserFS List <reiserfs-list@namesys.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] reiserfs: fix handling of device names with /'s in them
Date: Mon, 17 Jul 2006 10:55:11 -0400	[thread overview]
Message-ID: <44BBA4CF.8020901@suse.com> (raw)
In-Reply-To: <44BB3C42.1060309@namesys.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hans Reiser wrote:
> I don't understand your patch and cannot support it as it is written.  
> Perhaps you can call me and explain it on the phone.

I seriously can't tell if you're deliberately trying to be difficult or
not. It's a simple "replace / with ! before sending the name to procfs."

Reiserfs requests that a procfs directory called
/proc/fs/reiserfs/<blockdev> be created. Some block devices contain
slashes, so with cciss/c123 it attempts to create a directory called
/proc/fs/reiserfs/cciss/c123, but cciss/ doesn't exist, shouldn't, and
never will. In order to create a single path component, "cciss/c123"
becomes "cciss!c123." This is consistent with how sysfs does it now. For
a real example, change the "-" in device mapper block names to "/" and
see what happens.

Regardless, it's already been checked into mainline as change
6fbe82a952790c634ea6035c223a01a81377daf1.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEu6TPLPWxlyuTD7IRAvFTAJ9MYmmhSljmJTYFFlQvwS1G5AWdWQCglN0u
FCxA4sTIi/O5KRsZ38vzT1c=
=M7gO
-----END PGP SIGNATURE-----

  reply	other threads:[~2006-07-17 14:54 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6xQ4C-6NB-43@gated-at.bofh.it>
     [not found] ` <6xQea-6ZX-13@gated-at.bofh.it>
2006-07-14 16:10   ` [PATCH] reiserfs: fix handling of device names with /'s in them Bodo Eggert
2006-07-14 17:50     ` Jeff Mahoney
2006-07-16  7:12       ` Hans Reiser
2006-07-16 15:56         ` Jeffrey Mahoney
2006-07-16 18:14           ` Hans Reiser
2006-07-16 22:17             ` Jeff Mahoney
2006-07-17  1:21               ` Hans Reiser
2006-07-17  1:50                 ` Jeffrey Mahoney
2006-07-17  3:02                   ` Hans Reiser
2006-07-17  3:17                     ` Jeffrey Mahoney
2006-07-17  7:29                       ` Hans Reiser
2006-07-17 14:55                         ` Jeff Mahoney [this message]
2006-07-17 18:19                           ` Hans Reiser
2006-07-17 18:38                             ` Jeff Mahoney
2006-07-17 19:07                               ` Hans Reiser
2006-07-17 19:59                                 ` Jeff Mahoney
2006-07-17 21:03                                   ` Hans Reiser
2006-07-17 22:26                                     ` Rudy Zijlstra
2006-07-18  0:26                                     ` Horst von Brand
2006-07-18 16:38                                     ` Jan Engelhardt
2006-07-18 18:37                                 ` Pekka Enberg
2006-07-17 18:08                     ` Valdis.Kletnieks
2006-07-17 18:16                       ` Jeff Mahoney
2006-07-17 18:53                         ` Hans Reiser
2006-07-17 19:07                           ` Jeff Mahoney
2006-07-17 18:27                       ` Hans Reiser
2006-07-17 19:52                         ` Valdis.Kletnieks
2006-07-12 16:42 Jeff Mahoney
2006-07-12 16:57 ` Eric Dumazet
2006-07-12 17:02   ` Jeff Mahoney
2006-07-13  0:55 ` Andrew Morton
2006-07-13  3:51   ` Hans Reiser
2006-07-13  4:00     ` Andrew Morton
2006-07-13  7:34       ` Hans Reiser
2006-07-13  5:23   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44BBA4CF.8020901@suse.com \
    --to=jeffm@suse.com \
    --cc=7eggert@gmx.de \
    --cc=akpm@osdl.org \
    --cc=dada1@cosmosbay.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reiser@namesys.com \
    --cc=reiserfs-list@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox