Re: Lindent cleanup (was Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.)

Tomasz Kłoczko
2006-07-24T08:52:11Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2273 bytes --]

On Mon, 24 Jul 2006, Stefan Richter wrote:
[..]
>> IMO it is sill possible add general rule "allways use Lindent" because
>> indent can be dissabled/enabled aroud code inccorectly formated by add
>> control comments like:
>>
>> /* *INDENT-OFF* */
>> /* *INDENT-ON* */
>>
>> If it will be widely used probably it will allow better identify some
>> indent problems.
>
> IMHO: Write code for cpp, cc, as --- but not for any other
> processor-de-jour. All those processors (formatters, checkers etc.) are
> fine to *inspect* code for formal or semantic problems. But this should
> not lead to thousands more or less obscure processor keywords sprinkled
> all over the sources --- bloating them and making them confusing.

*If* it will be allowed by some kind of coding style rules IMO use indent
control comments will be good use *only* for files (not for piece of
files) for mark by subsystem maintainer "don't touch this using formaters
without inform me". IMO allow formating only below main level Linux kernel
developers (read: below Linus & close co. :) will only make this process
longer (read: less effective). Time neccessary for make progress from
current ~10% to ~90% is in this case very importand (will allow cut amount
of flames ;).

Finally probably best will be good add point in release procedure
something like: "use on whole tree Lindent and commit changes before bump
to final release". Only first this kind patch will be very huge. All other
will be small or very small.

IMO for good start for above will be send to all Linux maintainers kind
plain message for try review changes produced by Lindent (by add to
announce message small comment about this). Only after this IMO it will be
possible good disscuss on current indend rules.

Anyway .. disscuss on subject without this people will be pointless.

I'll try to monitor diffstat for each next release and generate
kind of "status: using Lindent on curent Linux tree". Probably
this can help on using indent on Linux tree.

kloczek
--
-----------------------------------------------------------
*Ludzie nie mają problemów, tylko sobie sami je stwarzają*
-----------------------------------------------------------
Tomasz Kłoczko, sys adm @zie.pg.gda.pl|*e-mail: kloczek@rudy.mif.pg.gda.pl*