Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.

Stefan Richter
2006-07-21T14:11:40Z

Pekka J Enberg wrote:
> On Fri, 21 Jul 2006, Stefan Richter wrote:
>> Contributors can't know what the (supposed) _agreements_ are.
>>
>> Contributors can only know what the _documented conventions_ are.
>
> Life gets easier when you accept the fact that there are different
> conventions within the kernel, driven by maintainer preference. Which is
> why it is impossible to document a definite set of conventions too.
> CodingStyle really is just a good approximation
[...]

What can a contributor do when he comes across code which deviates from
CodingStyle? He cannot tell whether the initial developer wasn't forced
to adhere to CodingStyle or the maintainer wants it that way. So, the
contributor
- could ask the maintainer for his ruleset before writing a patch, or
- could simply write the patch and wait if the maintainer feels need to
demand adjustments.
I am not sure which strategy will consume less time of contributor and
maintainer.
--
Stefan Richter
-=====-=-==- -=== =--==