Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.

Stefan Richter
2006-07-21T11:05:31Z

Pekka J Enberg wrote:
> At least Andrew seems to prefer cleaning up in the same patch. Anyway, I
> don't think Jeff meant that you shouldn't do any cleanups, but that you
> should try to respect the existing style as much possible.

First and foremost, respect that the Linux sources need to have a
minimum level of stylistic uniformity.

> There are
> things that are almost generally agreed upon, such as removal of redundant
> typecasts, redundant wrappers, and moving assignment out of if statement
> expression. Formatting and the dreaded sizeof thing, however,
> are not, so it is best to keep them as-is.

Contributors can't know what the (supposed) _agreements_ are.

Contributors can only know what the _documented conventions_ are.
--
Stefan Richter
-=====-=-==- -=== =--==