Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.

Pekka J Enberg
2006-07-21T11:20:05Z

At some point in time, I wrote:
> > There are things that are almost generally agreed upon, such as
> > removal of redundant typecasts, redundant wrappers, and moving
> > assignment out of if statement expression. Formatting and the dreaded
> > sizeof thing, however, are not, so it is best to keep them as-is.

On Fri, 21 Jul 2006, Stefan Richter wrote:
> Contributors can't know what the (supposed) _agreements_ are.
>
> Contributors can only know what the _documented conventions_ are.

Life gets easier when you accept the fact that there are different
conventions within the kernel, driven by maintainer preference. Which is
why it is impossible to document a definite set of conventions too.
CodingStyle really is just a good approximation what kernel code should
look like. If you deviate from it too much, everyone agrees that
you're violating it, but there definitely is room for maintainer
preference. As a contributor, when you accept that, you'll have much
greater chances of getting your patches merged.

Pekka