From: Jeff Garzik <jgarzik@pobox.com>
To: Pekka J Enberg <penberg@cs.Helsinki.FI>
Cc: Panagiotis Issaris <takis@gna.org>,
Rolf Eike Beer <eike-kernel@sf-tec.de>,
Panagiotis Issaris <takis@lumumba.uhasselt.be>,
linux-kernel@vger.kernel.org, len.brown@intel.com,
chas@cmf.nrl.navy.mil, miquel@df.uba.ar, kkeil@suse.de,
benh@kernel.crashing.org, video4linux-list@redhat.com,
rmk+mmc@arm.linux.org.uk, Neela.Kolli@engenio.com,
vandrove@vc.cvut.cz, adaplas@pol.net, thomas@winischhofer.net,
weissg@vienna.at, philb@gnu.org,
linux-pcmcia@lists.infradead.org, jkmaline@cc.hut.fi,
paulus@samba.org
Subject: Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.
Date: Fri, 21 Jul 2006 17:17:30 -0400 [thread overview]
Message-ID: <44C1446A.7060008@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0607211308590.25982@sbz-30.cs.Helsinki.FI>
Pekka J Enberg wrote:
> On Fri, 21 Jul 2006, Panagiotis Issaris wrote:
>> Ah okay. Up until now, I thought it would be okay to change the style of
>> the code if it was listed in the CodingStyle document and in any other
>> cause should be left untouched as it would be left to the maintainers
>> personal preference. That's why I explicitly asked about the "if ((buf =
>> kmalloc(...)==NULL) -> buf = kmalloc(...); if (!buf)" type of changes.
>>
>> Ofcourse, I should have put cosmetic changes in a separate patch anyway.
>
> At least Andrew seems to prefer cleaning up in the same patch. Anyway, I
> don't think Jeff meant that you shouldn't do any cleanups, but that you
> should try to respect the existing style as much possible.
Correct.
Jeff
next prev parent reply other threads:[~2006-07-21 21:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 19:05 [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc Panagiotis Issaris
2006-07-21 6:50 ` Rolf Eike Beer
2006-07-21 6:58 ` Pekka Enberg
2006-07-21 7:05 ` Jeff Garzik
2006-07-21 9:09 ` Stefan Richter
2006-07-21 10:20 ` Jesper Juhl
2006-07-21 10:35 ` Panagiotis Issaris
2006-07-21 10:38 ` Pekka J Enberg
2006-07-21 10:55 ` Stefan Richter
2006-07-22 17:58 ` Tomasz Kłoczko
2006-07-22 18:25 ` Stefan Richter
2006-07-22 18:35 ` Tomasz Kłoczko
2006-07-22 20:02 ` Jeff Garzik
2006-07-22 20:55 ` Tomasz Kłoczko
2006-07-23 11:20 ` Alexey Dobriyan
2006-07-23 17:55 ` Tomasz Kłoczko
2006-07-23 18:24 ` Michael Buesch
2006-07-24 0:10 ` Tomasz Kłoczko
2006-07-24 0:49 ` Tomasz Kłoczko
2006-07-24 8:03 ` Lindent cleanup (was Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.) Stefan Richter
2006-07-24 8:52 ` Tomasz Kłoczko
2006-07-23 15:16 ` [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc Stefan Richter
2006-07-23 18:09 ` Tomasz Kłoczko
2006-07-21 10:53 ` Stefan Richter
2006-07-21 11:09 ` Stefan Richter
2006-07-21 21:16 ` Jeff Garzik
2006-07-21 21:15 ` Jeff Garzik
2006-07-22 6:20 ` Stefan Richter
2006-07-21 9:32 ` [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc Panagiotis Issaris
2006-07-21 10:14 ` Pekka J Enberg
2006-07-21 10:42 ` Panagiotis Issaris
2006-07-21 11:02 ` Stefan Richter
2006-07-21 11:20 ` Pekka J Enberg
2006-07-21 14:08 ` Stefan Richter
2006-07-21 21:17 ` Jeff Garzik [this message]
2006-07-21 10:21 ` [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc Daniel K.
2006-07-21 10:30 ` Panagiotis Issaris
2006-07-21 11:12 ` Rolf Eike Beer
2006-07-21 12:35 ` Dmitry Torokhov
2006-07-21 12:39 ` Panagiotis Issaris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44C1446A.7060008@pobox.com \
--to=jgarzik@pobox.com \
--cc=Neela.Kolli@engenio.com \
--cc=adaplas@pol.net \
--cc=benh@kernel.crashing.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=eike-kernel@sf-tec.de \
--cc=jkmaline@cc.hut.fi \
--cc=kkeil@suse.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=miquel@df.uba.ar \
--cc=paulus@samba.org \
--cc=penberg@cs.Helsinki.FI \
--cc=philb@gnu.org \
--cc=rmk+mmc@arm.linux.org.uk \
--cc=takis@gna.org \
--cc=takis@lumumba.uhasselt.be \
--cc=thomas@winischhofer.net \
--cc=vandrove@vc.cvut.cz \
--cc=video4linux-list@redhat.com \
--cc=weissg@vienna.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox