public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vasily Averin <vvs@sw.ru>
To: "Ju, Seokmann" <Seokmann.Ju@lsil.com>
Cc: James.Bottomley@SteelEye.com, akpm@osdl.org,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Patro,
	Sumant" <Sumant.Patro@lsil.com>,
	yang.bo@lsil.com
Subject: Re: [PATCH 1/3] scsi : megaraid_{mm,mbox}: 64-bit DMA capability checker
Date: Mon, 24 Jul 2006 12:08:48 +0400	[thread overview]
Message-ID: <44C48010.40603@sw.ru> (raw)
In-Reply-To: <890BF3111FB9484E9526987D912B261902CDA9@NAMAIL3.ad.lsil.com>

Ju, Seokmann wrote:
> Hi,
> With patch, the driver access PCIconfiguration space with dedicated 
> offset to read a signature. If the signature read, it means that the 
> controller has capability to handle 64-bit DMA. 
> Without this patch, the driver blindly claimed 64-bit DMA capability
> without checking with controller.
> The issue has been reported by Vasily Averin. 

> +	if (((magic64 == HBA_SIGNATURE_64_BIT) &&
> +		(adapter->pdev->subsystem_device !=
> +		PCI_SUBSYS_ID_MEGARAID_SATA_150_6)) ||

I would note that I've reported about issue on SATA_150_4 device. I can also
accept that similar patch fixes this issue.

> +		(adapter->pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC && 
> +		adapter->pdev->device == PCI_DEVICE_ID_VERDE) || 
> +		(adapter->pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC && 
> +		adapter->pdev->device == PCI_DEVICE_ID_DOBSON) || 
> +		(adapter->pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC && 
> +		adapter->pdev->device == PCI_DEVICE_ID_LINDSAY) || 
> +		(adapter->pdev->vendor == PCI_VENDOR_ID_DELL && 
> +		adapter->pdev->device == PCI_DEVICE_ID_PERC4_DI_EVERGLADES) || 
> +		(adapter->pdev->vendor == PCI_VENDOR_ID_DELL && 
> +		adapter->pdev->device == PCI_DEVICE_ID_PERC4E_DI_KOBUK)) {

Thank you,
	Vasily Averin

SWsoft Virtuozzo/OpenVZ Linux kernel team

       reply	other threads:[~2006-07-24  8:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <890BF3111FB9484E9526987D912B261902CDA9@NAMAIL3.ad.lsil.com>
2006-07-24  8:08 ` Vasily Averin [this message]
2006-07-25 14:44 [PATCH 1/3] scsi : megaraid_{mm,mbox}: 64-bit DMA capability checker Ju, Seokmann
2006-07-25 15:10 ` Arjan van de Ven
2006-07-28 18:20 ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44C48010.40603@sw.ru \
    --to=vvs@sw.ru \
    --cc=James.Bottomley@SteelEye.com \
    --cc=Seokmann.Ju@lsil.com \
    --cc=Sumant.Patro@lsil.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=yang.bo@lsil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox