public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andi Kleen <ak@muc.de>, Andrew Morton <akpm@osdl.org>,
	Keir Fraser <Keir.Fraser@cl.cam.ac.uk>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Zachary Amsden <zach@vmware.com>, Pratap <pratap@vmware.com>,
	Chris Wright <chrisw@sous-sol.org>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] cpuid neatening.
Date: Mon, 24 Jul 2006 16:58:07 -0700	[thread overview]
Message-ID: <44C55E8F.2020200@zytor.com> (raw)
In-Reply-To: <1153527194.13699.34.camel@localhost.localdomain>

Rusty Russell wrote:
> Roll all the cpuid asm into one __cpuid call.  It's a little neater,
> and also means only one place to patch for paravirtualization.

The whole point of those is to avoid the unnecessary write to memory and 
pick it back up again.  This patch reintroduces that ugliness.

You don't want to make it the obvious multi-return macro, either, 
because that code is known to break some old versions of gcc.

	-hpa

  parent reply	other threads:[~2006-07-24 23:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1153526643.13699.18.camel@localhost.localdomain>
2006-07-22  0:05 ` [PATCH 2/6] reboot.c to use struct Xgt_desc_struct Rusty Russell
     [not found] ` <1153526798.13699.23.camel@localhost.localdomain>
2006-07-22  0:13   ` [PATCH 6/6] cpuid neatening Rusty Russell
2006-07-22  4:12     ` David Schwartz
2006-07-24 23:58     ` H. Peter Anvin [this message]
2006-07-25  1:41       ` Andi Kleen
     [not found] <20060722000328.cd9e7e0e.akpm@osdl.org>
2006-07-22 15:22 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44C55E8F.2020200@zytor.com \
    --to=hpa@zytor.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=chrisw@sous-sol.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pratap@vmware.com \
    --cc=rusty@rustcorp.com.au \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox