* Linguistic fixes for Documentation/kbuild/
@ 2006-07-27 20:14 Jan Engelhardt
2006-07-27 21:01 ` Sam Ravnborg
2006-07-28 17:37 ` Randy.Dunlap
0 siblings, 2 replies; 4+ messages in thread
From: Jan Engelhardt @ 2006-07-27 20:14 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Michael Elizabeth Chastain, Adrian Bunk,
Linux Kernel Mailing List
[-- Attachment #1: Type: TEXT/PLAIN, Size: 964 bytes --]
Hello,
I have done a look-through through Documentation/kbuild/ and my corrections
(proposed) are attached. It is bzipped because the uncompressed diff is
41KB and may have get stuck on the magic list limit (30 or 40, I believe 40).
Cc'ed are original author Michael (responsible for comitting changes to
these files?), Sam (kbuild maintainer), Adrian (-trivial maintainer).
Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
kconfig-language.txt | 12 +--
makefiles.txt | 184 ++++++++++++++++++++++++++-------------------------
modules.txt | 119 ++++++++++++++++----------------
3 files changed, 160 insertions(+), 155 deletions(-)
I have noticed more inconsistencies ("architecture-specific" vs
"architecture specific"), mixed use of American -z- and British -s-
(such as customize/customise), and more. This patch is a simple start that
does not go into language pickyness. Except maybe for commas :)
Regards,
Jan Engelhardt
--
[-- Attachment #2: Type: APPLICATION/x-bzip2, Size: 11636 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Linguistic fixes for Documentation/kbuild/
2006-07-27 20:14 Linguistic fixes for Documentation/kbuild/ Jan Engelhardt
@ 2006-07-27 21:01 ` Sam Ravnborg
2006-07-28 17:37 ` Randy.Dunlap
1 sibling, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2006-07-27 21:01 UTC (permalink / raw)
To: Jan Engelhardt
Cc: Michael Elizabeth Chastain, Adrian Bunk,
Linux Kernel Mailing List
On Thu, Jul 27, 2006 at 10:14:29PM +0200, Jan Engelhardt wrote:
> Hello,
>
>
> I have done a look-through through Documentation/kbuild/ and my corrections
> (proposed) are attached. It is bzipped because the uncompressed diff is
> 41KB and may have get stuck on the magic list limit (30 or 40, I believe 40).
>
> Cc'ed are original author Michael (responsible for comitting changes to
> these files?), Sam (kbuild maintainer), Adrian (-trivial maintainer).
Applied - as three individual patches.
Roman Zippel takes care of kconfig-language. The two others are mostly
me who introduce speling mistakes et al.
Thanks!
Sam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Linguistic fixes for Documentation/kbuild/
2006-07-27 20:14 Linguistic fixes for Documentation/kbuild/ Jan Engelhardt
2006-07-27 21:01 ` Sam Ravnborg
@ 2006-07-28 17:37 ` Randy.Dunlap
2006-07-28 17:45 ` Auke Kok
1 sibling, 1 reply; 4+ messages in thread
From: Randy.Dunlap @ 2006-07-28 17:37 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: sam, mec, bunk, linux-kernel
On Thu, 27 Jul 2006 22:14:29 +0200 (MEST) Jan Engelhardt wrote:
> Hello,
>
>
> I have done a look-through through Documentation/kbuild/ and my corrections
> (proposed) are attached. It is bzipped because the uncompressed diff is
> 41KB and may have get stuck on the magic list limit (30 or 40, I believe 40).
or 80 or 100 KB ? Certainly more than 40 KB.
> Cc'ed are original author Michael (responsible for comitting changes to
> these files?), Sam (kbuild maintainer), Adrian (-trivial maintainer).
>
> Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
>
> kconfig-language.txt | 12 +--
> makefiles.txt | 184 ++++++++++++++++++++++++++-------------------------
> modules.txt | 119 ++++++++++++++++----------------
> 3 files changed, 160 insertions(+), 155 deletions(-)
>
> I have noticed more inconsistencies ("architecture-specific" vs
> "architecture specific"), mixed use of American -z- and British -s-
> (such as customize/customise), and more. This patch is a simple start that
> does not go into language pickyness. Except maybe for commas :)
architecture-specific when used as an adjective.
makefiles.txt:
- This tell kbuild that there is one object in that directory named
+ This tell kbuild that there is one object in that directory, named
s/tell/tells/
- In the above example cflags-y will be assinged the the option
+ In the above example, cflags-y will be assinged the the option
s/assigned/assigned/
s/the the/the/
- cc-option is used to check if $(CC) support a given option, and not
+ cc-option is used to check if $(CC) supports a given option, and not
supported to use an optional second option.
maybe "and if not supported, to use an optional second argument." ?
- A typcal pattern in a Kbuild file lok like this:
+ A typcal pattern in a Kbuild file looks like this:
s/typcal/typical/
So if a config symbol evaluate to 'm', kbuild will still build
evaluates ?
- the binary. In other words Kbuild handle hostprogs-m exactly
- like hostprogs-y. But only hostprogs-y is recommend used
- when no CONFIG symbol are involved.
+ the binary. In other words, Kbuild handles hostprogs-m exactly
+ like hostprogs-y. But only hostprogs-y is recommended to be used
+ when no CONFIG symbols are involved.
- This includes building boot records
- - Preparing initrd images and the like
+ - Preparing initrd images and thelike
"the like" was good.
- $(head-y) list objects to be linked first in vmlinux.
- $(libs-y) list directories where a lib.a archive can be located.
- The rest list directories where a built-in.o object file can be located.
+ $(head-y) lists objects to be linked first in vmlinux.
+ $(libs-y) lists directories where a lib.a archive can be located.
+ The rest lists directories where a built-in.o object file can be
+ located.
"rest" looks plural to me there, so "list" is OK IMO.
- When the rule is evaluated it is checked to see if any files
- needs an update, or the commandline has changed since last
+ When the rule is evaluated, it is checked to see if any files
+ needs an update, or the command line has changed since the last
s/needs/need/
(or "file needs")
- $(targets) are assinged all potential targets, herby kbuild knows
+ $(targets) are assinged all potential targets, by which kbuild knows
assigned
---
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Linguistic fixes for Documentation/kbuild/
2006-07-28 17:37 ` Randy.Dunlap
@ 2006-07-28 17:45 ` Auke Kok
0 siblings, 0 replies; 4+ messages in thread
From: Auke Kok @ 2006-07-28 17:45 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: Jan Engelhardt, sam, mec, bunk, linux-kernel
Randy.Dunlap wrote:
> On Thu, 27 Jul 2006 22:14:29 +0200 (MEST) Jan Engelhardt wrote:
>> I have done a look-through through Documentation/kbuild/ and my corrections
>> (proposed) are attached. It is bzipped because the uncompressed diff is
>> 41KB and may have get stuck on the magic list limit (30 or 40, I believe 40).
>
> or 80 or 100 KB ? Certainly more than 40 KB.
From "http://vger.kernel.org/majordomo-info.html":
"Message size exceeding 100 000 characters causes blocking."
So that's 97KB :)
Cheers,
Auke
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-07-28 17:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-27 20:14 Linguistic fixes for Documentation/kbuild/ Jan Engelhardt
2006-07-27 21:01 ` Sam Ravnborg
2006-07-28 17:37 ` Randy.Dunlap
2006-07-28 17:45 ` Auke Kok
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox