public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Al Boldi <a1426z@gawab.com>, Rob Landley <rob@landley.net>,
	linux-kernel@vger.kernel.org, torvalds@osdl.org,
	stable@kernel.org, akpm@osdl.org, chrisw@sous-sol.org,
	grim@undead.cc
Subject: Re: [PATCH] initramfs:  Allow rootfs to use tmpfs instead of ramfs
Date: Sun, 30 Jul 2006 11:48:41 -0700	[thread overview]
Message-ID: <44CCFF09.2000106@zytor.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0607301750080.10648@blonde.wat.veritas.com>

Hugh Dickins wrote:
> On Sun, 30 Jul 2006, Al Boldi wrote:
>> Replugs rootfs to use tmpfs instead of ramfs as a Kconfig option.
> 
> Why?  Looking further down we see what you should have explained here:
>> + This option switches rootfs so that it uses tmpfs rather than ramfs
>> + for its file storage.  This makes rootfs swappable so having a large
>> + initrd or initramfs image won't eat up valuable RAM.
> 
> Now, I'm far from an expert on initramfs and early userspace, but my
> understanding is that the "init" of a (properly designed) initramfs
> would pretty much "rm -rf" everything in the initramfs before passing
> control to the final "init".  So (almost?) no valuable RAM is eaten
> up, nor the less valuable swap if you do extend this to tmpfs (unless
> something gets left open, which I think should not be the case).
> 
> So I'm inclined to say that this patch is simply unnecessary.  But
> if people who know better think it's a good thing, I've no objection
> (though I've not tried it): the Kconfiggery looks more likely to
> provoke argument than the tmpfs/ramfs mods.
> 

Well...

There is some justification: embedded people would like to load 
inittmpfs and then continue running.

The main issue -- which I am not sure what effect this patch has -- is 
that we would really like to move initramfs initialization even earlier 
in the kernel, so that it can include firmware loading for built-in 
device drivers, for example.

Thus, if this patch makes it harder to push initramfs initialization 
earlier, it's probably a bad thing.  If not, the author of the patch 
really needs to explain why it works and why it doesn't add new 
dependencies to the initialization order.

Saying "this is a trivial patch" and pushing it on the -stable tree 
doesn't inspire too much confidence, as initialization is subtle.

	-hpa

  reply	other threads:[~2006-07-30 18:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-30 15:08 [PATCH] initramfs: Allow rootfs to use tmpfs instead of ramfs Al Boldi
2006-07-30 17:36 ` Hugh Dickins
2006-07-30 18:48   ` H. Peter Anvin [this message]
2006-07-30 21:03     ` Al Boldi
2006-07-31 19:24       ` H. Peter Anvin
2006-07-31 14:35     ` Rob Landley
2006-07-30 21:03   ` Al Boldi
2006-07-30 17:51 ` [stable] " Greg KH
2006-07-30 21:03   ` Al Boldi
2006-07-31 19:25     ` H. Peter Anvin
2006-07-31 20:58       ` Al Boldi
2006-07-31 23:20         ` H. Peter Anvin
2006-07-31 19:30     ` Chris Wright
2006-07-31 20:58       ` Al Boldi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44CCFF09.2000106@zytor.com \
    --to=hpa@zytor.com \
    --cc=a1426z@gawab.com \
    --cc=akpm@osdl.org \
    --cc=chrisw@sous-sol.org \
    --cc=grim@undead.cc \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@landley.net \
    --cc=stable@kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox