* Re: [PATCH 12 of 13] Pass the mm struct into the pgd_free code so the mm is available here [not found] <8235caea9d688b78ce4b.1154462450@ezr> @ 2006-08-02 3:14 ` Andi Kleen 2006-08-02 6:25 ` [Xen-devel] " Zachary Amsden 0 siblings, 1 reply; 3+ messages in thread From: Andi Kleen @ 2006-08-02 3:14 UTC (permalink / raw) To: virtualization Cc: Jeremy Fitzhardinge, Andrew Morton, Xen-devel, Ian Pratt, Linux Kernel, Chris Wright, Eric W. Biederman, Christoph Lameter nst char *arch_vma_name(struct vm_area_struct *vma); > > +#ifndef pgd_free_mm > +#define pgd_free_mm(mm) pgd_free((mm)->pgd) > +#endif Sorry, but these ifdefs are too ugly. I would prefer if you just updated all architectures, even though it will make the patch somewhat bigger -Andi ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] Re: [PATCH 12 of 13] Pass the mm struct into the pgd_free code so the mm is available here 2006-08-02 3:14 ` [PATCH 12 of 13] Pass the mm struct into the pgd_free code so the mm is available here Andi Kleen @ 2006-08-02 6:25 ` Zachary Amsden 2006-08-02 7:13 ` Chris Wright 0 siblings, 1 reply; 3+ messages in thread From: Zachary Amsden @ 2006-08-02 6:25 UTC (permalink / raw) To: Andi Kleen Cc: virtualization, Andrew Morton, Xen-devel, Jeremy Fitzhardinge, Linux Kernel, Chris Wright, Ian Pratt, Eric W. Biederman, Christoph Lameter Andi Kleen wrote: > nst char *arch_vma_name(struct vm_area_struct *vma); > >> >> +#ifndef pgd_free_mm >> +#define pgd_free_mm(mm) pgd_free((mm)->pgd) >> +#endif >> > > Sorry, but these ifdefs are too ugly. I would prefer if you > just updated all architectures, even though it will make the patch > somewhat bigger > I'm fine with doing that, and yes this is ugly. Will take awhile though - for efficiency of mercurial patch tools, I deprecated all architectures but i386, x86_64, and um from my local tree. <Slaps head>. Zach ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] Re: [PATCH 12 of 13] Pass the mm struct into the pgd_free code so the mm is available here 2006-08-02 6:25 ` [Xen-devel] " Zachary Amsden @ 2006-08-02 7:13 ` Chris Wright 0 siblings, 0 replies; 3+ messages in thread From: Chris Wright @ 2006-08-02 7:13 UTC (permalink / raw) To: Zachary Amsden Cc: Andi Kleen, virtualization, Andrew Morton, Xen-devel, Jeremy Fitzhardinge, Linux Kernel, Chris Wright, Ian Pratt, Eric W. Biederman, Christoph Lameter * Zachary Amsden (zach@vmware.com) wrote: > Andi Kleen wrote: > >nst char *arch_vma_name(struct vm_area_struct *vma); > > > >> > >>+#ifndef pgd_free_mm > >>+#define pgd_free_mm(mm) pgd_free((mm)->pgd) > >>+#endif > >> > > > >Sorry, but these ifdefs are too ugly. I would prefer if you > >just updated all architectures, even though it will make the patch > >somewhat bigger > > > I'm fine with doing that, and yes this is ugly. Will take awhile though > - for efficiency of mercurial patch tools, I deprecated all > architectures but i386, x86_64, and um from my local tree. <Slaps head>. While you're at it, can you please make sure there's some nice changelog comments. The current one only has diffstat. thanks, -chris ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-08-02 7:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <8235caea9d688b78ce4b.1154462450@ezr>
2006-08-02 3:14 ` [PATCH 12 of 13] Pass the mm struct into the pgd_free code so the mm is available here Andi Kleen
2006-08-02 6:25 ` [Xen-devel] " Zachary Amsden
2006-08-02 7:13 ` Chris Wright
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox