From: Jes Sorensen <jes@sgi.com>
To: Shailabh Nagar <nagar@watson.ibm.com>
Cc: Jay Lan <jlan@sgi.com>, Andrew Morton <akpm@osdl.org>,
lkml <linux-kernel@vger.kernel.org>,
Balbir Singh <balbir@in.ibm.com>,
Chris Sturtivant <csturtiv@sgi.com>, Tony Ernst <tee@sgi.com>
Subject: Re: [patch 3/3] convert CONFIG tag for a few accounting data used by CSA
Date: Wed, 02 Aug 2006 09:26:02 +0200 [thread overview]
Message-ID: <44D0538A.3090600@sgi.com> (raw)
In-Reply-To: <44CE6AE7.8020304@watson.ibm.com>
Shailabh Nagar wrote:
> Jay Lan wrote:
>> There were a few accounting data/macros that are used in CSA
>> but are #ifdef'ed inside CONFIG_BSD_PROCESS_ACCT. This patch is
>> to change those ifdef's from CONFIG_BSD_PROCESS_ACCT to
>> CONFIG_CSA_ACCT. A few defines are moved from kernel/acct.c and
>> include/linux/acct.h to kernel/csa.c and include/linux/csa_kern.h.
>>
>>
>> Signed-off-by: Jay Lan <jlan@sgi.com>
[snip]
>> +#ifdef CONFIG_CSA_ACCT
>> +extern void acct_update_integrals(struct task_struct *tsk);
>> +extern void acct_clear_integrals(struct task_struct *tsk);
>> +#else
>> +#define acct_update_integrals(x) do { } while (0)
>> +#define acct_clear_integrals(task) do { } while (0)
>> +#endif
>> +
>
> static inlines preferred
Huh? Is that a preference to the taskstat project? For the kernel
itself it makes no difference.
Cheers,
Jes
next prev parent reply other threads:[~2006-08-02 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 19:23 [patch 3/3] convert CONFIG tag for a few accounting data used by CSA Jay Lan
2006-07-31 20:41 ` Shailabh Nagar
2006-08-02 7:26 ` Jes Sorensen [this message]
2006-08-02 7:31 ` Andrew Morton
2006-08-02 7:45 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D0538A.3090600@sgi.com \
--to=jes@sgi.com \
--cc=akpm@osdl.org \
--cc=balbir@in.ibm.com \
--cc=csturtiv@sgi.com \
--cc=jlan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nagar@watson.ibm.com \
--cc=tee@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox