From: Daniel Phillips <phillips@google.com>
To: Dave Jones <davej@redhat.com>
Cc: Nate Diller <nate.diller@gmail.com>,
Andrew Morton <akpm@osdl.org>, Jens Axboe <axboe@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm] [2/2] Add the Elevator I/O scheduler
Date: Thu, 03 Aug 2006 18:31:03 -0700 [thread overview]
Message-ID: <44D2A357.6020108@google.com> (raw)
In-Reply-To: <20060803235304.GB7265@redhat.com>
Dave Jones wrote:
> > +#define ops_count(el, req) ((el)->ops[req->flags & REQ_RW ? 1 : 0])
> > +#define sec_count(el, req) ((el)->sec[req->flags & REQ_RW ? 1 : 0])
> > +#define sweep_latency(el, req) ((el)->sweep_latency[(req)->flags &
> > REQ_RW ? 1 : 0])
>
> You like your macros huh ? :)
That is, can they please be inline functions.
Regards,
Daniel
next prev parent reply other threads:[~2006-08-04 1:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-03 23:03 [PATCH -mm] [2/2] Add the Elevator I/O scheduler Nate Diller
2006-08-03 23:53 ` Dave Jones
2006-08-04 0:06 ` Nate Diller
2006-08-04 1:28 ` Daniel Phillips
2006-08-07 20:07 ` Steven Rostedt
2006-08-04 1:31 ` Daniel Phillips [this message]
2006-08-03 23:55 ` Adrian Bunk
2006-08-04 0:08 ` Nate Diller
2006-08-04 5:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D2A357.6020108@google.com \
--to=phillips@google.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nate.diller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox