From: Pierre Ossman <drzeus-list@drzeus.cx>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [MMC] Fix base address configuration in wbsd
Date: Sun, 06 Aug 2006 22:57:35 +0200 [thread overview]
Message-ID: <44D657BF.6070004@drzeus.cx> (raw)
In-Reply-To: <20060806204842.GE16816@flint.arm.linux.org.uk>
Russell King wrote:
> On Sun, Aug 06, 2006 at 10:22:23PM +0200, Pierre Ossman wrote:
>> There were some confusion about base I/O variables in the wbsd driver.
>> Seems like things have been working on shear luck so far. The global 'io'
>> variable (used when manually configuring the resources) was used instead of
>> the local 'base' variable.
>
> Applied, thanks.
>
> Shouldn't "base" be something other than "int" (eg, unsigned long) ?
unsigned short would probably be the right<tm> thing as the resource is
16 bits. I haven't seen it as big enough issue to warrant a patch.
> Also, wbsd_init() takes base, irq, dma but passes wbsd_request_resources
> io, irq and dma? I suspect more fixes are on their way... 8)
*sigh*
And I thought this brown paper bag was just temporary...
Rgds
Pierre
next prev parent reply other threads:[~2006-08-06 20:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-06 20:22 [PATCH] [MMC] Fix base address configuration in wbsd Pierre Ossman
2006-08-06 20:48 ` Russell King
2006-08-06 20:57 ` Pierre Ossman [this message]
2006-08-06 21:05 ` Russell King
2006-08-06 21:29 ` Pierre Ossman
2006-08-06 21:35 ` Ben Dooks
2006-08-06 21:52 ` Pierre Ossman
2006-08-06 23:32 ` Alan Cox
2006-08-06 23:19 ` Pierre Ossman
2006-08-06 21:13 ` Randy.Dunlap
2006-08-06 21:30 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D657BF.6070004@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox