From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: use persistent allocation for cursor blinking.
Date: Mon, 07 Aug 2006 07:46:43 +0800 [thread overview]
Message-ID: <44D67F63.4050200@gmail.com> (raw)
In-Reply-To: <20060805212639.GF5417@ucw.cz>
Pavel Machek wrote:
> Hi!
>
>> Every time the console cursor blinks, we do a kmalloc/kfree pair.
>> This patch turns that into a single allocation.
>>
>> This allocation was the most frequent kmalloc I saw on my test box.
>>
>> Signed-off-by: Dave Jones <davej@redhat.com>
>>
>>
>> --- linux-2.6.14/drivers/video/console/softcursor.c~ 2005-12-28 18:40:08.000000000 -0500
>> +++ linux-2.6.14/drivers/video/console/softcursor.c 2005-12-28 18:45:50.000000000 -0500
>> @@ -23,7 +23,9 @@ int soft_cursor(struct fb_info *info, st
>> unsigned int buf_align = info->pixmap.buf_align - 1;
>> unsigned int i, size, dsize, s_pitch, d_pitch;
>> struct fb_image *image;
>> - u8 *dst, *src;
>> + u8 *dst;
>> + static u8 *src=NULL;
>> + static int allocsize=0;
>>
>
> Spaces around = ? And perhaps it does not need to be initialized when
> it is static?
>
I already sent an updated patch, so your concerns are gone.
Tony
prev parent reply other threads:[~2006-08-06 23:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 18:56 use persistent allocation for cursor blinking Dave Jones
2006-08-01 19:15 ` Roland Dreier
2006-08-01 19:31 ` Dave Jones
2006-08-01 22:20 ` Alan Cox
2006-08-02 1:20 ` [PATCH] fbcon: Use " Antonino A. Daplas
2006-08-02 1:28 ` [PATCH RESEND] " Antonino A. Daplas
2006-08-02 1:28 ` [PATCH] " Dave Jones
2006-08-01 22:17 ` use " Alan Cox
2006-08-01 22:39 ` Dave Jones
2006-08-01 23:12 ` Alan Cox
2006-08-05 21:26 ` Pavel Machek
2006-08-06 23:46 ` Antonino A. Daplas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D67F63.4050200@gmail.com \
--to=adaplas@gmail.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox