From: Arjan van de Ven <arjan@linux.intel.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, davem@redhat.com,
sds@tycho.nsa.gov, jack@suse.cz, dwmw2@infradead.org,
tony.luck@intel.com, jdike@karaya.com,
James.Bottomley@HansenPartnership.com
Subject: Re: How to lock current->signal->tty
Date: Tue, 08 Aug 2006 08:10:51 -0700 [thread overview]
Message-ID: <44D8A97B.30607@linux.intel.com> (raw)
In-Reply-To: <1155050242.5729.88.camel@localhost.localdomain>
Alan Cox wrote:
> The biggest crawly horror I've found so far in auditing the tty locking
> is current->signal->tty. The tty layer currently and explicitly protects
> this using tty_mutex. The core kernel likewise knows about this.
>
> Unfortunately:
> Dquot passes the tty to tty_write_message without locking
> arch/ia64/kernel/unanligned seems to write to it without locking
these two have absolutely no business at all using anything tty.... they should
just use printk with KERN_EMERG or whatever
next prev parent reply other threads:[~2006-08-08 15:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 15:17 How to lock current->signal->tty Alan Cox
2006-08-08 15:10 ` Arjan van de Ven [this message]
2006-08-08 15:44 ` Alan Cox
2006-08-08 16:41 ` Luck, Tony
2006-08-08 17:50 ` Alan Cox
2006-08-09 8:09 ` Jes Sorensen
2006-08-09 10:44 ` Alan Cox
2006-08-09 11:26 ` Jes Sorensen
2006-08-09 16:24 ` Luck, Tony
2006-08-09 18:10 ` Jes Sorensen
2006-08-08 22:06 ` Jan Kara
2006-08-08 17:11 ` Stephen Smalley
2006-08-08 17:43 ` Alan Cox
2006-08-08 17:44 ` Stephen Smalley
2006-08-08 18:10 ` Alan Cox
2006-08-08 20:02 ` Stephen Smalley
2006-08-13 21:34 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2006-08-09 4:01 Albert Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D8A97B.30607@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@redhat.com \
--cc=dwmw2@infradead.org \
--cc=jack@suse.cz \
--cc=jdike@karaya.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox