Re: [PATCH 2/6] ehea: pHYP interface

Anton Blanchard
2006-08-11T21:14:10Z

Hi,

> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_phyp.c 1969-12-31 16:00:00.000000000 -0800

> +u64 ehea_h_alloc_resource_eq(const u64 hcp_adapter_handle,
...
> +u64 hipz_h_reregister_pmr(const u64 adapter_handle,
...
> +static inline int hcp_galpas_ctor(struct h_galpas *galpas,

Be nice to have some consistent names, hipz_ and hcp_ is kind of
cryptic.

> +#define H_QP_CR_STATE_RESET 0x0000010000000000 /* Reset */

Probably want ULL on here and the other 64bit constants.

Anton