Re: How to lock current->signal->tty

Arjan van de Ven
2006-08-08T15:11:02Z

Alan Cox wrote:
> The biggest crawly horror I've found so far in auditing the tty locking
> is current->signal->tty. The tty layer currently and explicitly protects
> this using tty_mutex. The core kernel likewise knows about this.
>
> Unfortunately:
> Dquot passes the tty to tty_write_message without locking
> arch/ia64/kernel/unanligned seems to write to it without locking

these two have absolutely no business at all using anything tty.... they should
just use printk with KERN_EMERG or whatever