Re: How to lock current->signal->tty

Jan Kara
2006-08-08T22:05:25Z

> Ar Maw, 2006-08-08 am 08:10 -0700, ysgrifennodd Arjan van de Ven:
> > > Unfortunately:
> > > Dquot passes the tty to tty_write_message without locking
> > > arch/ia64/kernel/unanligned seems to write to it without locking
> >
> > these two have absolutely no business at all using anything tty.... they should
> > just use printk with KERN_EMERG or whatever
>
> Dquot does - it writes to the controlling tty of the process exceeding
> quota . That is standard Unix behaviour
Yes. On one hand I find this behaviour kind of inconsistent (Unix usually
just returns an error code and that's it) but on the other hand there is
no other good way of informing user about e.g. exceeded quota soft
limit.
So I'll just fix up the tty locking ;).

Honza

--
Jan Kara <jack@suse.cz>
SuSE CR Labs