From: "Jan Beulich" <jbeulich@novell.com>
To: "Andi Kleen" <ak@suse.de>
Cc: <stsp@aknet.ru>, "Chuck Ebbert" <76306.1226@compuserve.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [patch] i386: annotate the rest of entry.s::nmi
Date: Thu, 10 Aug 2006 10:34:15 +0200 [thread overview]
Message-ID: <44DB0BA7.76E4.0078.0@novell.com> (raw)
In-Reply-To: <200608101026.08606.ak@suse.de>
>>> Andi Kleen <ak@suse.de> 10.08.06 10:26 >>>
>On Thursday 10 August 2006 10:23, Jan Beulich wrote:
>> >>> Chuck Ebbert <76306.1226@compuserve.com> 10.08.06 06:59 >>>
>> >Part of the NMI handler is missing annotations. Just moving
>> >the RING0_INT_FRAME macro fixes it. And additional comments
>> >should warn anyone changing this to recheck the annotations.
>>
>> I have to admit that I can't see the value of this movement;
>
>Should I drop it again?
I would suggest so, but would also want to wait for Chuck to perhaps
provide some background on why he felt these annotations were
useful.
Jan
next prev parent reply other threads:[~2006-08-10 8:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 4:59 [patch] i386: annotate the rest of entry.s::nmi Chuck Ebbert
2006-08-10 5:20 ` Andi Kleen
2006-08-10 8:23 ` Jan Beulich
2006-08-10 8:26 ` Andi Kleen
2006-08-10 8:34 ` Jan Beulich [this message]
2006-08-11 17:46 ` Stas Sergeev
2006-08-14 6:52 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2006-08-10 12:48 Chuck Ebbert
2006-08-10 12:58 ` Andi Kleen
2006-08-10 13:39 ` Jan Beulich
2006-08-10 17:39 Chuck Ebbert
2006-08-11 7:10 ` Jan Beulich
2006-08-11 23:13 Chuck Ebbert
2006-08-14 6:55 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44DB0BA7.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=76306.1226@compuserve.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=stsp@aknet.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox