Re: [PATCH 2/9] sector_t format string

Alexey Dobriyan
2006-08-10T20:42:25Z

On Thu, Aug 10, 2006 at 12:57:47PM -0700, Andrew Morton wrote:
> On Thu, 10 Aug 2006 23:44:40 +0400
> Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > On Thu, Aug 10, 2006 at 12:17:47PM -0700, Joel Becker wrote:
> > > On Wed, Aug 09, 2006 at 11:40:19PM -0700, Andrew Morton wrote:
> > > > On Wed, 09 Aug 2006 18:20:43 -0700
> > > > Mingming Cao <cmm@us.ibm.com> wrote:
> > > >
> > > > > Define SECTOR_FMT to print sector_t in proper format
> > > >
> > > > We've thus-far avoided doing this. In fact a similar construct in
> > > > device-mapper was recently removed.
> > >
> > > Yeah, OCFS2 had similar formats, and we were asked to change
> > > them to naked casts before inclusion. Seems quite consistent with the
> > > rest of the kernel.
> >
> > Will
> >
> > printk("%S", sector_t);
> >
> > kill at least one kitten?
>
> It would be really nice to be able to define local enhancements like this
> to printf. It would solve lots of these problems quite nicely.
>
> Bus alas, there's no way (afaik) to teach __attribute__((format)) about
> them, so gcc will warn.

Arrrgh!

from gcc-local(1)
- gcc recognizes a new format attribute, kprintf, to deal with the ex-
tra format arguments `%b', `%r', and `%z' used in the OpenBSD kernel.

One word: bastards.